Skip to contentSkip to conversation

build in SATA drivers to the -xen kernel for x86_64

PATCH In review Sean Dague 3 participants 6 messages Mar 29, 2006

lore
Share & tools
lore

Sean Dague

author
#0 lore raw

PATCH 1/1 build in SATA drivers to the -xen kernel for x86_64

This patch adds in the SATA drivers that are supported in the -xen0 kernel. Because the default behavior of xen is to reboot on a dom0 crash (i.e. not finding root filesystem), and the xen0 kernel supported SATA directly, a number of people (including myself) got caught by the switch over.

Long term, we probably want to modularize more of the kernel, and make initrd building more of the default, however this should ease people's transition from the -xen0 => -xen kernel for testing on x86_64.

-Sean

Signature · 3 lines
Sean Dague
IBM Linux Technology Center                     email: [email protected]
Open Hypervisor Team                           alt: [email protected]

# HG changeset patch
# User [email protected]
# Node ID caa11d7c7be09c4fce6367e83e311de126ad18be
# Parent b094f951870b6a524fbae46fdae3aaa398dd14b8
Add in SATA devices supported in the -xen0 kernel. This doesn't add much weight to the kernel, and has the benefit of surprising less people when they move from the -xen0 to -xen kernel on hardware that used to boot without an initrd.

buildconfigs/linux-defconfig_xen_x86_64 +8 -8
diff -r b094f951870b -r caa11d7c7be0 buildconfigs/linux-defconfig_xen_x86_64
@@ -1,7 +1,7 @@
 #
 # Automatically generated make config: don't edit
 # Linux kernel version: 2.6.16-xen
-# Mon Mar 27 09:43:44 2006
+# Tue Mar 28 17:11:43 2006
 #
 CONFIG_X86_64=y
 CONFIG_64BIT=y
@@ -967,13 +967,13 @@ CONFIG_SCSI_SATA_NV=m
 CONFIG_SCSI_SATA_NV=m
 CONFIG_SCSI_PDC_ADMA=m
 CONFIG_SCSI_SATA_QSTOR=m
-CONFIG_SCSI_SATA_PROMISE=m
-CONFIG_SCSI_SATA_SX4=m
-CONFIG_SCSI_SATA_SIL=m
-CONFIG_SCSI_SATA_SIL24=m
-CONFIG_SCSI_SATA_SIS=m
-CONFIG_SCSI_SATA_ULI=m
-CONFIG_SCSI_SATA_VIA=m
+CONFIG_SCSI_SATA_PROMISE=y
+CONFIG_SCSI_SATA_SX4=y
+CONFIG_SCSI_SATA_SIL=y
+CONFIG_SCSI_SATA_SIL24=y
+CONFIG_SCSI_SATA_SIS=y
+CONFIG_SCSI_SATA_ULI=y
+CONFIG_SCSI_SATA_VIA=y
 CONFIG_SCSI_SATA_VITESSE=m
 CONFIG_SCSI_SATA_INTEL_COMBINED=y
 CONFIG_SCSI_BUSLOGIC=m

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

#1 lore raw
Quoted 8 lines · Sean Dague

This patch adds in the SATA drivers that are supported in the -xen0 kernel. Because the default behavior of xen is to reboot on a dom0 crash (i.e. not finding root filesystem), and the xen0 kernel supported SATA directly, a number of people (including myself) got caught by the switch over.

Long term, we probably want to modularize more of the kernel, and make initrd building more of the default, however this should ease people's transition from the -xen0 => -xen kernel for testing on x86_64.

If this is done at all, it should be done for i386 as well. I think it's debatable really -- -xen is supposed to be a modular kernel build. If people want stuff built in they should modify the config or use -xen0.

-- Keir

author
#2 lore raw
Quoted 11 lines · Keir Fraser
Quoted 8 lines · Sean Dague

This patch adds in the SATA drivers that are supported in the -xen0 kernel.
Because the default behavior of xen is to reboot on a dom0 crash (i.e. not
finding root filesystem), and the xen0 kernel supported SATA directly, a
number of people (including myself) got caught by the switch over.

Quoted 8 lines
Quoted 3 lines

Long term, we probably want to modularize more of the kernel, and make initrd building more of the default, however this should ease people's transition from the -xen0 => -xen kernel for testing on x86_64.

If this is done at all, it should be done for i386 as well. I think it's debatable really -- -xen is supposed to be a modular kernel build. If people want stuff built in they should modify the config or use -xen0.

Well, SATA is significantly more relevant for x86_64, as a very large percentage of x86_64 systems are SATA based. I doubt that even 1/2 of the IDE controllers that are compiled in by default for the x86_64 kernel have ever existed in an x86_64 system. If we're shooting for truely modular, we should start removing the IDE drivers from the -xen kernel.

I would agree that changes here are debateable, however given that xen default behavior is to reboot on dom0 fail (i.e. no screen log unless on serial), a large number of users have been tripped up by this process on the -xen kernels, and will find it hard to debug. The approach of making the -xen0 storage drivers also on in the -xen kernel just makes it a bit more predicable. (i.e. -xen == -xen0 + lots of other device support). While it isn't that today, I think it would make more sense if it was that way. But then again, that's just my $0.02. :)

An alternate (or even in addition to any changes to the -xen kernel) would be to default xen behavior to "noreboot", which would make it a lot clearer to users *why* their system doesn't come up with Xen on the first try.

-Sean

Signature · 3 lines
Sean Dague
IBM Linux Technology Center                     email: [email protected]
Open Hypervisor Team                           alt: [email protected]

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

#3 lore raw
Quoted 3 lines · Sean Dague

An alternate (or even in addition to any changes to the -xen kernel) would be to default xen behavior to "noreboot", which would make it a lot clearer to users *why* their system doesn't come up with Xen on the first try.

What is native kernel behaviour when it fails to find its rootfs? Does it reboot?

-- Keir

#4 lore raw
Quoted 2 lines · * Keir Fraser ([email protected]) wrote:

What is native kernel behaviour when it fails to find its rootfs? Does it reboot?

Default, no, just panic. If you add kernel cmdline param it will reboot, 'panic=<timeout>'

thanks,
-chris

author
#5 lore raw
Quoted 6 lines · Chris Wright
Quoted 2 lines · * Keir Fraser ([email protected]) wrote:

What is native kernel behaviour when it fails to find its rootfs? Does it reboot?

Default, no, just panic. If you add kernel cmdline param it will reboot, 'panic=<timeout>'

Right, but Xen reboots on a dom0 kernel panic by default, which ends up completely masking why the dom0 kernel paniced, as your screen blips off immediately (or at least it does for me). :)

Keeping the message on the CRT that dom0 paniced because it couldn't find the root block device would dispense with a lot of questions.

-Sean

Signature · 3 lines
Sean Dague
IBM Linux Technology Center                     email: [email protected]
Open Hypervisor Team                           alt: [email protected]

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel