Skip to contentSkip to conversation

Add gcc 4.0 support

PATCH In review Thiemo Seufer 8 participants 16 messages Feb 15, 2006 – Apr 3, 2006 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Add gcc 4.0 support

Hello all,

the appended patch

- Adds detection of gcc commandline flag support, based on the theory "If it exists, we want to use it".
- Uses this to add enough gcc4 flag magic to OP_FLAGS, and remove the specialcasing for gcc3 as well as the bail out for gcc4.
- Makes CFLAGS and OP_CLFAGS distinct sets because options like -O0 are useful for debugging in CFLAGS but break qemu in OP_CFLAGS.
- Updates the ppc.ld script to work with gcc4.
- Adds preliminary mips/mipsel support to Makefile.target.
- Adds to RETURN and FORCE_RET a "memory" constraint to ensure it works as optimisation barrier.

Caveats:
- Those changes weren't tested with earlier compilers. The linker script probably requires some more recent ld. Please test if it still works for you.
- The -malign-functions=0 is now used as a fallback for -fno-align-functions on all architectures, not only on i386. This might be wrong.

Tested on Debian unstable on powerpc, while working on improving the mips emulation support.

Thiemo

Index: Makefile.target
===================================================================
RCS file: /sources/qemu/qemu/Makefile.target,v
retrieving revision 1.93

Makefile.target +38 -29
diff -u -p -r1.93 Makefile.target
@@ -17,6 +17,14 @@ ifdef CONFIG_USER_ONLY
 VPATH+=:$(SRC_PATH)/linux-user
 DEFINES+=-I$(SRC_PATH)/linux-user -I$(SRC_PATH)/linux-user/$(TARGET_ARCH)
 endif
+
+# cc-option
+# Usage: CFLAGS += $(call cc-option, -falign-functions=0, -malign-functions=0)
+
+cc-option = $(shell if $(CC) $(CFLAGS) $(1) -S -o /dev/null -xc /dev/null \
+             > /dev/null 2>&1; then echo "$(1)"; else echo "$(2)"; fi ;)
+
+
 CFLAGS=-Wall -O2 -g -fno-strict-aliasing
 #CFLAGS+=-Werror
 LDFLAGS=-g
@@ -65,15 +73,19 @@ ifdef CONFIG_STATIC
 LDFLAGS+=-static
 endif
 
-ifeq ($(ARCH),i386)
-CFLAGS+=-fomit-frame-pointer
-OP_CFLAGS=$(CFLAGS) -mpreferred-stack-boundary=2
-ifeq ($(HAVE_GCC3_OPTIONS),yes)
-OP_CFLAGS+= -falign-functions=0 -fno-gcse
-else
-OP_CFLAGS+= -malign-functions=0
-endif
+# We require -O2 to avoid the stack setup prologue in EXIT_TB
+OP_CFLAGS = -Wall -O2 -g -fno-strict-aliasing
+OP_CFLAGS += $(call cc-option, -fno-reorder-blocks, "")
+OP_CFLAGS += $(call cc-option, -fno-tree-ch, "")
+OP_CFLAGS += $(call cc-option, -fno-optimize-sibling-calls, "")
+OP_CFLAGS += $(call cc-option, -fno-crossjumping, "")
+OP_CFLAGS += $(call cc-option, -fno-align-labels, "")
+OP_CFLAGS += $(call cc-option, -fno-align-jumps, "")
+OP_CFLAGS += $(call cc-option, -fno-align-functions, -malign-functions=0)
 
+ifeq ($(ARCH),i386)
+CFLAGS += -fomit-frame-pointer
+OP_CFLAGS += -fomit-frame-pointer -preferred-stack-boundary=2
 ifdef TARGET_GPROF
 USE_I386_LD=y
 endif
@@ -91,64 +103,61 @@ endif
 endif
 
 ifeq ($(ARCH),x86_64)
-OP_CFLAGS=$(CFLAGS) -falign-functions=0
 LDFLAGS+=-Wl,-T,$(SRC_PATH)/x86_64.ld
 endif
 
 ifeq ($(ARCH),ppc)
-CFLAGS+= -D__powerpc__
-OP_CFLAGS=$(CFLAGS)
+CFLAGS += -D__powerpc__
 LDFLAGS+=-Wl,-T,$(SRC_PATH)/ppc.ld
 endif
 
 ifeq ($(ARCH),s390)
-OP_CFLAGS=$(CFLAGS)
 LDFLAGS+=-Wl,-T,$(SRC_PATH)/s390.ld
 endif
 
 ifeq ($(ARCH),sparc)
-CFLAGS+=-m32 -ffixed-g1 -ffixed-g2 -ffixed-g3 -ffixed-g6
-LDFLAGS+=-m32
-OP_CFLAGS=$(CFLAGS) -fno-delayed-branch -ffixed-i0
-HELPER_CFLAGS=$(CFLAGS) -ffixed-i0 -mflat
+CFLAGS += -m32 -ffixed-g1 -ffixed-g2 -ffixed-g3 -ffixed-g6
+LDFLAGS += -m32
+OP_CFLAGS += -m32 -ffixed-g1 -ffixed-g2 -ffixed-g3 -ffixed-g6 \
+	-fno-delayed-branch -ffixed-i0
+HELPER_CFLAGS = $(CFLAGS) -ffixed-i0 -mflat
 # -static is used to avoid g1/g3 usage by the dynamic linker
 LDFLAGS+=-Wl,-T,$(SRC_PATH)/sparc.ld -static
 endif
 
 ifeq ($(ARCH),sparc64)
-CFLAGS+=-m64 -ffixed-g1 -ffixed-g2 -ffixed-g3 -ffixed-g6
-LDFLAGS+=-m64
-OP_CFLAGS=$(CFLAGS) -fno-delayed-branch -ffixed-i0
+CFLAGS += -m64 -ffixed-g1 -ffixed-g2 -ffixed-g3 -ffixed-g6
+LDFLAGS += -m64
+OP_CFLAGS += -m64 -ffixed-g1 -ffixed-g2 -ffixed-g3 -ffixed-g6 \
+	-fno-delayed-branch -ffixed-i0
 endif
 
 ifeq ($(ARCH),alpha)
-# -msmall-data is not used because we want two-instruction relocations
-# for the constant constructions
-OP_CFLAGS=-Wall -O2 -g
 # Ensure there's only a single GP
 CFLAGS += -msmall-data
+# -msmall-data is not used for OP_CFLAGS because we want
+# two-instruction relocations for the constant constructions
 LDFLAGS+=-Wl,-T,$(SRC_PATH)/alpha.ld
 endif
 
 ifeq ($(ARCH),ia64)
 CFLAGS += -mno-sdata
-OP_CFLAGS=$(CFLAGS)
+OP_CFLAGS += -mno-sdata
 LDFLAGS+=-Wl,-G0 -Wl,-T,$(SRC_PATH)/ia64.ld
 endif
 
 ifeq ($(ARCH),arm)
-OP_CFLAGS=$(CFLAGS) -mno-sched-prolog -fno-omit-frame-pointer
+OP_CFLAGS += -mno-sched-prolog -fno-omit-frame-pointer
 LDFLAGS+=-Wl,-T,$(SRC_PATH)/arm.ld
 endif
 
 ifeq ($(ARCH),m68k)
-OP_CFLAGS=$(CFLAGS) -fomit-frame-pointer
-LDFLAGS+=-Wl,-T,m68k.ld
+OP_CFLAGS += -fomit-frame-pointer
+LDFLAGS+=-Wl,-T,$(SRC_PATH)/m68k.ld
 endif
 
-ifeq ($(HAVE_GCC3_OPTIONS),yes)
-# very important to generate a return at the end of every operation
-OP_CFLAGS+=-fno-reorder-blocks -fno-optimize-sibling-calls
+ifeq ($(ARCH),mips)
+LDFLAGS+=-Wl,-T,$(SRC_PATH)/mips.ld
 endif
 
 ifeq ($(CONFIG_DARWIN),yes)

Index: configure
===================================================================
RCS file: /sources/qemu/qemu/configure,v
retrieving revision 1.82

configure +1 -32
diff -u -p -r1.82 configure
@@ -274,34 +274,6 @@ if test "$cpu" = "sparc64" -o "$cpu" = "
     hostlongbits="64"
 fi
 
-# check gcc options support
-cat > $TMPC <<EOF
-int main(void) {
-}
-EOF
-
-have_gcc3_options="no"
-if $cc -fno-reorder-blocks -fno-optimize-sibling-calls -o $TMPO $TMPC 2> /dev/null ; then
-   have_gcc3_options="yes"
-fi
-
-# Check for gcc4
-if test "$check_gcc" = "yes" ; then
-    cat > $TMPC <<EOF
-#if __GNUC__ >= 4
-#error gcc4
-#endif
-int main(){return 0;}
-EOF
-    if ! $cc -o $TMPO $TMPC 2>/dev/null ; then
-        echo "ERROR: \"$cc\" looks like gcc 4.x"
-        echo "QEMU is known to have problems when compiled with gcc 4.x"
-        echo "It is recommended that you use gcc 3.x to build QEMU"
-        echo "To use this compiler anyway, configure with --disable-gcc-check"
-        exit 1;
-    fi
-fi
-
 ##########################################
 # SDL probe
 
@@ -388,7 +360,7 @@ echo "  --enabled-dsound         enable 
 echo "  --fmod-lib               path to FMOD library"
 echo "  --fmod-inc               path to FMOD includes"
 echo ""
-echo "NOTE: The object files are build at the place where configure is launched"
+echo "NOTE: The object files are built at the place where configure is launched"
 exit 1
 fi
 
@@ -477,9 +449,6 @@ echo "docdir=$docdir" >> $config_mak
 echo "#define CONFIG_QEMU_SHAREDIR \"$datadir\"" >> $config_h
 echo "MAKE=$make" >> $config_mak
 echo "CC=$cc" >> $config_mak
-if test "$have_gcc3_options" = "yes" ; then
-  echo "HAVE_GCC3_OPTIONS=yes" >> $config_mak
-fi
 echo "HOST_CC=$host_cc" >> $config_mak
 echo "AR=$ar" >> $config_mak
 echo "STRIP=$strip -s -R .comment -R .note" >> $config_mak

Index: dyngen-exec.h
===================================================================
RCS file: /sources/qemu/qemu/dyngen-exec.h,v
retrieving revision 1.26

dyngen-exec.h +1 -1
diff -u -p -r1.26 dyngen-exec.h
@@ -155,7 +155,7 @@ extern int printf(const char *, ...);
 #endif
 
 /* force GCC to generate only one epilog at the end of the function */
-#define FORCE_RET() asm volatile ("");
+#define FORCE_RET() __asm__ __volatile__("" : : : "memory");
 
 #ifndef OPPROTO
 #define OPPROTO

Index: ppc.ld
===================================================================
RCS file: /sources/qemu/qemu/ppc.ld,v
retrieving revision 1.2

ppc.ld +156 -68

261 lines not on this page · raw message

Index: target-mips/exec.h
===================================================================
RCS file: /sources/qemu/qemu/target-mips/exec.h,v
retrieving revision 1.6

exec.h +2 -2
diff -u -p -r1.6 exec.h
@@ -31,9 +31,9 @@ register double FT2 asm(FREG2);
 #endif
 
 #if defined (DEBUG_OP)
-#define RETURN() __asm__ __volatile__("nop");
+# define RETURN() __asm__ __volatile__("nop" : : : "memory");
 #else
-#define RETURN() __asm__ __volatile__("");
+# define RETURN() __asm__ __volatile__("" : : : "memory");
 #endif
 
 #include "cpu.h"

Index: target-ppc/exec.h
===================================================================
RCS file: /sources/qemu/qemu/target-ppc/exec.h,v
retrieving revision 1.13

exec.h +2 -2
diff -u -p -r1.13 exec.h
@@ -38,9 +38,9 @@ register uint32_t T2 asm(AREG3);
 #define FT2 (env->ft2)
 
 #if defined (DEBUG_OP)
-#define RETURN() __asm__ __volatile__("nop");
+#define RETURN() __asm__ __volatile__("nop" : : : "memory");
 #else
-#define RETURN() __asm__ __volatile__("");
+#define RETURN() __asm__ __volatile__("" : : : "memory");
 #endif
 
 #include "cpu.h"
mips.ld new file +225 -0

225 lines not on this page · raw message

mipsel.ld new file +225 -0

225 lines not on this page · raw message

#1 lore raw

Hi,

AFAIR gcc 4 had different problems on different platforms. Does your patch solve them?

Ciao,
Dscho

#2 lore raw
Quoted 4 lines · Johannes Schindelin

Hi,

AFAIR gcc 4 had different problems on different platforms. Does your patch solve them?

I tested only Linux/powerpc and checked the disassembly there. I believe the patch will improve the situation generically for all platforms, but I may have missed some bits.

If you describe a specific problem I can probably tell you if it is covered by my patch.

Thiemo

#3 lore raw

Hi,

Quoted 2 lines · Thiemo Seufer

If you describe a specific problem I can probably tell you if it is covered by my patch.

I had the impression something went wrong on MinGW32: I did not try myself, but IIRC there were multiple "ret" statements per compiled oplet. Since I was not experiencing the problem, maybe some people who did could help me out here?

Ciao,
Dscho

#4 lore raw
In reply to Thiemo Seufer
Quoted 24 lines · Thiemo Seufer

Hello all,

the appended patch

- Adds detection of gcc commandline flag support, based on the theory "If it exists, we want to use it".
- Uses this to add enough gcc4 flag magic to OP_FLAGS, and remove the specialcasing for gcc3 as well as the bail out for gcc4.
- Makes CFLAGS and OP_CLFAGS distinct sets because options like -O0 are useful for debugging in CFLAGS but break qemu in OP_CFLAGS.
- Updates the ppc.ld script to work with gcc4.
- Adds preliminary mips/mipsel support to Makefile.target.
- Adds to RETURN and FORCE_RET a "memory" constraint to ensure it works as optimisation barrier.

Caveats:
- Those changes weren't tested with earlier compilers. The linker script probably requires some more recent ld. Please test if it still works for you.
- The -malign-functions=0 is now used as a fallback for -fno-align-functions on all architectures, not only on i386. This might be wrong.

Quoted 2 lines

Tested on Debian unstable on powerpc, while working on improving the mips emulation support.

Updated version, note that this is still not suitable for CVS since x86 fails to build with it.

Thiemo

Makefile.target renamed from Makefile.target.orig +38 -29
Index: Makefile.target
===================================================================
@@ -17,6 +17,14 @@
 VPATH+=:$(SRC_PATH)/linux-user
 DEFINES+=-I$(SRC_PATH)/linux-user -I$(SRC_PATH)/linux-user/$(TARGET_ARCH)
 endif
+
+# cc-option
+# Usage: CFLAGS += $(call cc-option, -falign-functions=0, -malign-functions=0)
+
+cc-option = $(shell if $(CC) $(CFLAGS) $(1) -S -o /dev/null -xc /dev/null \
+             > /dev/null 2>&1; then echo "$(1)"; else echo "$(2)"; fi ;)
+
+
 CFLAGS=-Wall -O2 -g -fno-strict-aliasing
 #CFLAGS+=-Werror
 LDFLAGS=-g
@@ -65,15 +73,19 @@
 LDFLAGS+=-static
 endif
 
-ifeq ($(ARCH),i386)
-CFLAGS+=-fomit-frame-pointer
-OP_CFLAGS=$(CFLAGS) -mpreferred-stack-boundary=2
-ifeq ($(HAVE_GCC3_OPTIONS),yes)
-OP_CFLAGS+= -falign-functions=0 -fno-gcse
-else
-OP_CFLAGS+= -malign-functions=0
-endif
+# We require -O2 to avoid the stack setup prologue in EXIT_TB
+OP_CFLAGS = -Wall -O2 -g -fno-strict-aliasing
+OP_CFLAGS += $(call cc-option, -fno-reorder-blocks, "")
+OP_CFLAGS += $(call cc-option, -fno-tree-ch, "")
+OP_CFLAGS += $(call cc-option, -fno-optimize-sibling-calls, "")
+OP_CFLAGS += $(call cc-option, -fno-crossjumping, "")
+OP_CFLAGS += $(call cc-option, -fno-align-labels, "")
+OP_CFLAGS += $(call cc-option, -fno-align-jumps, "")
+OP_CFLAGS += $(call cc-option, -fno-align-functions, -malign-functions=0)
 
+ifeq ($(ARCH),i386)
+CFLAGS += -fomit-frame-pointer
+OP_CFLAGS += -fomit-frame-pointer -preferred-stack-boundary=2
 ifdef TARGET_GPROF
 USE_I386_LD=y
 endif
@@ -91,64 +103,61 @@
 endif
 
 ifeq ($(ARCH),x86_64)
-OP_CFLAGS=$(CFLAGS) -falign-functions=0
 LDFLAGS+=-Wl,-T,$(SRC_PATH)/x86_64.ld
 endif
 
 ifeq ($(ARCH),ppc)
-CFLAGS+= -D__powerpc__
-OP_CFLAGS=$(CFLAGS)
+CFLAGS += -D__powerpc__
 LDFLAGS+=-Wl,-T,$(SRC_PATH)/ppc.ld
 endif
 
 ifeq ($(ARCH),s390)
-OP_CFLAGS=$(CFLAGS)
 LDFLAGS+=-Wl,-T,$(SRC_PATH)/s390.ld
 endif
 
 ifeq ($(ARCH),sparc)
-CFLAGS+=-m32 -ffixed-g1 -ffixed-g2 -ffixed-g3 -ffixed-g6
-LDFLAGS+=-m32
-OP_CFLAGS=$(CFLAGS) -fno-delayed-branch -ffixed-i0
-HELPER_CFLAGS=$(CFLAGS) -ffixed-i0 -mflat
+CFLAGS += -m32 -ffixed-g1 -ffixed-g2 -ffixed-g3 -ffixed-g6
+LDFLAGS += -m32
+OP_CFLAGS += -m32 -ffixed-g1 -ffixed-g2 -ffixed-g3 -ffixed-g6 \
+	-fno-delayed-branch -ffixed-i0
+HELPER_CFLAGS = $(CFLAGS) -ffixed-i0 -mflat
 # -static is used to avoid g1/g3 usage by the dynamic linker
 LDFLAGS+=-Wl,-T,$(SRC_PATH)/sparc.ld -static
 endif
 
 ifeq ($(ARCH),sparc64)
-CFLAGS+=-m64 -ffixed-g1 -ffixed-g2 -ffixed-g3 -ffixed-g6
-LDFLAGS+=-m64
-OP_CFLAGS=$(CFLAGS) -fno-delayed-branch -ffixed-i0
+CFLAGS += -m64 -ffixed-g1 -ffixed-g2 -ffixed-g3 -ffixed-g6
+LDFLAGS += -m64
+OP_CFLAGS += -m64 -ffixed-g1 -ffixed-g2 -ffixed-g3 -ffixed-g6 \
+	-fno-delayed-branch -ffixed-i0
 endif
 
 ifeq ($(ARCH),alpha)
-# -msmall-data is not used because we want two-instruction relocations
-# for the constant constructions
-OP_CFLAGS=-Wall -O2 -g
 # Ensure there's only a single GP
 CFLAGS += -msmall-data
+# -msmall-data is not used for OP_CFLAGS because we want
+# two-instruction relocations for the constant constructions
 LDFLAGS+=-Wl,-T,$(SRC_PATH)/alpha.ld
 endif
 
 ifeq ($(ARCH),ia64)
 CFLAGS += -mno-sdata
-OP_CFLAGS=$(CFLAGS)
+OP_CFLAGS += -mno-sdata
 LDFLAGS+=-Wl,-G0 -Wl,-T,$(SRC_PATH)/ia64.ld
 endif
 
 ifeq ($(ARCH),arm)
-OP_CFLAGS=$(CFLAGS) -mno-sched-prolog -fno-omit-frame-pointer
+OP_CFLAGS += -mno-sched-prolog -fno-omit-frame-pointer
 LDFLAGS+=-Wl,-T,$(SRC_PATH)/arm.ld
 endif
 
 ifeq ($(ARCH),m68k)
-OP_CFLAGS=$(CFLAGS) -fomit-frame-pointer
-LDFLAGS+=-Wl,-T,m68k.ld
+OP_CFLAGS += -fomit-frame-pointer
+LDFLAGS+=-Wl,-T,$(SRC_PATH)/m68k.ld
 endif
 
-ifeq ($(HAVE_GCC3_OPTIONS),yes)
-# very important to generate a return at the end of every operation
-OP_CFLAGS+=-fno-reorder-blocks -fno-optimize-sibling-calls
+ifeq ($(ARCH),mips)
+LDFLAGS+=-Wl,-T,$(SRC_PATH)/mips.ld
 endif
 
 ifeq ($(CONFIG_DARWIN),yes)
configure renamed from configure.orig +1 -32
Index: configure
===================================================================
@@ -291,34 +291,6 @@
     hostlongbits="64"
 fi
 
-# check gcc options support
-cat > $TMPC <<EOF
-int main(void) {
-}
-EOF
-
-have_gcc3_options="no"
-if $cc -fno-reorder-blocks -fno-optimize-sibling-calls -o $TMPO $TMPC 2> /dev/null ; then
-   have_gcc3_options="yes"
-fi
-
-# Check for gcc4
-if test "$check_gcc" = "yes" ; then
-    cat > $TMPC <<EOF
-#if __GNUC__ >= 4
-#error gcc4
-#endif
-int main(){return 0;}
-EOF
-    if ! $cc -o $TMPO $TMPC 2>/dev/null ; then
-        echo "ERROR: \"$cc\" looks like gcc 4.x"
-        echo "QEMU is known to have problems when compiled with gcc 4.x"
-        echo "It is recommended that you use gcc 3.x to build QEMU"
-        echo "To use this compiler anyway, configure with --disable-gcc-check"
-        exit 1;
-    fi
-fi
-
 ##########################################
 # SDL probe
 
@@ -409,7 +381,7 @@
 echo "  --fmod-lib               path to FMOD library"
 echo "  --fmod-inc               path to FMOD includes"
 echo ""
-echo "NOTE: The object files are build at the place where configure is launched"
+echo "NOTE: The object files are built at the place where configure is launched"
 exit 1
 fi
 
@@ -498,9 +470,6 @@
 echo "#define CONFIG_QEMU_SHAREDIR \"$datadir\"" >> $config_h
 echo "MAKE=$make" >> $config_mak
 echo "CC=$cc" >> $config_mak
-if test "$have_gcc3_options" = "yes" ; then
-  echo "HAVE_GCC3_OPTIONS=yes" >> $config_mak
-fi
 echo "HOST_CC=$host_cc" >> $config_mak
 echo "AR=$ar" >> $config_mak
 echo "STRIP=$strip -s -R .comment -R .note" >> $config_mak
dyngen-exec.h renamed from dyngen-exec.h.orig +1 -1
Index: dyngen-exec.h
===================================================================
@@ -155,7 +155,7 @@
 #endif
 
 /* force GCC to generate only one epilog at the end of the function */
-#define FORCE_RET() asm volatile ("");
+#define FORCE_RET() __asm__ __volatile__("" : : : "memory");
 
 #ifndef OPPROTO
 #define OPPROTO
ppc.ld renamed from ppc.ld.orig +156 -68

261 lines not on this page · raw message

exec.h renamed from exec.h.orig +2 -2
Index: target-mips/exec.h
===================================================================
@@ -31,9 +31,9 @@
 #endif
 
 #if defined (DEBUG_OP)
-#define RETURN() __asm__ __volatile__("nop");
+# define RETURN() __asm__ __volatile__("nop" : : : "memory");
 #else
-#define RETURN() __asm__ __volatile__("");
+# define RETURN() __asm__ __volatile__("" : : : "memory");
 #endif
 
 #include "cpu.h"
exec.h renamed from exec.h.orig +2 -2
Index: target-ppc/exec.h
===================================================================
@@ -38,9 +38,9 @@
 #define FT2 (env->ft2)
 
 #if defined (DEBUG_OP)
-#define RETURN() __asm__ __volatile__("nop");
+#define RETURN() __asm__ __volatile__("nop" : : : "memory");
 #else
-#define RETURN() __asm__ __volatile__("");
+#define RETURN() __asm__ __volatile__("" : : : "memory");
 #endif
 
 #include "cpu.h"
mips.ld new file +225 -0

225 lines not on this page · raw message

mipsel.ld new file +225 -0

225 lines not on this page · raw message

#5 lore raw

Out of curiosity, wouldn't it be better to specifically request that feature of gcc, with one of its myriad options, rather than forcing a rather large optimization sweep? I'm sure that -O2 is good generally, but using it as a kludge to get at one of the many things that it enables seems like a not-so-great-idea. Its like buying a restaurant so that you can get a chef's stove.

Please feel free to ignore me completely if you like, this is just my $0.02. :-)

JP

Quoted 1 line · Thiemo Seufer

+# We require -O2 to avoid the stack setup prologue in EXIT_TB

--
"Faith: Belief without evidence in what is told by one who speaks without knowledge, of things without parallel." - A.B.

#6 lore raw
Quoted 6 lines · John Davidorff Pell

Out of curiosity, wouldn't it be better to specifically request that feature of gcc, with one of its myriad options, rather than forcing a rather large optimization sweep? I'm sure that -O2 is good generally, but using it as a kludge to get at one of the many things that it enables seems like a not-so-great-idea. Its like buying a restaurant so that you can get a chef's stove.

Well, I went through the ppc disassembly and found no reason to disable -O2. Note that it was the default before, I only noticed the breakage when I lowered the global optimisation to -O0 for better debugging.

Thiemo

#7 lore raw

I was just thinking that by enabling the required feature individually, someone else could choose -O0 and not have to investigate why it fails. Its not like its a big deal, though. :-)

JP

P.S. Why does the list set the reply-to header, isn't that supposed to be a Bad Thing™?

Quoted 14 lines · Thiemo Seufer
Quoted 6 lines · John Davidorff Pell

Out of curiosity, wouldn't it be better to specifically request that feature of gcc, with one of its myriad options, rather than forcing a rather large optimization sweep? I'm sure that -O2 is good generally, but using it as a kludge to get at one of the many things that it enables seems like a not-so-great-idea. Its like buying a restaurant so that you can get a chef's stove.

Well, I went through the ppc disassembly and found no reason to disable -O2. Note that it was the default before, I only noticed the breakage when I lowered the global optimisation to -O0 for better debugging.

Quoted 7 lines

Thiemo

_______________________________________________
Qemu-devel mailing list
[email protected]
http://lists.nongnu.org/mailman/listinfo/qemu-devel

--
Blood is thicker than water... and much tastier.

#8 lore raw
Quoted 2 lines · John Davidorff Pell

P.S. Why does the list set the reply-to header, isn't that supposed to be a Bad Thing™?

Only according to some people :)
I hate when I reply to a list and the message goes to the guy and not to the list... (If someone enforces Reply-To in his mail I think however that it should remain).

#9 lore raw
Quoted 8 lines · Pascal Terjan
Quoted 2 lines · John Davidorff Pell

P.S. Why does the list set the reply-to header, isn't that supposed to be a Bad Thing™?

Only according to some people :)
I hate when I reply to a list and the message goes to the guy and not to the list... (If someone enforces Reply-To in his mail I think however that it should remain).

I kind of like it and wish that some lists would allow me to set it as a user-preference - there are so many lists and I really never ever want to reply to *just* the person (ever, ever, ever).

reply-to the list is good for me

Auke

#10 lore raw
Quoted 7 lines · sofar

I kind of like it and wish that some lists would allow me to set it as a user-preference - there are so many lists and I really never ever want to reply to *just* the person (ever, ever, ever).

reply-to the list is good for me

Auke

Actually, I'm for making it a user preference. This might be difficult to implement in the mailing list software but is IMVHO a worthwhile addition.

That way users who find mangled mails convient can get what they want without having to compromise the rest of us (sane) users..

Of course there are those who will say that this should be a mail client option, not a mailing list problem.

Well, here is what I have to do to work around mailing lists of both types (those that do mangle and those that don't):

reply command (looks at From: and ignores Reply-To: - necessary to reply just to the person if the list does reply-to mangling)

reply-to-reply command (uses Reply-To: - I have never actually used this for anything ;) but it is there for those cases such as when I get an individual email that has a Reply-To: on it for whatever reason)

reply-to-replied command (looks at the To: header, this is a bit counterintutive but provides an easy way to reply directly to the list when the list does not do reply-to mangling)

reply-to-group (replies to everyone in the To: and Cc: and etc.. - generally avoided as it often results in duplicate mails)

reply-to-list (replies to the mailing list as defined in a config file - this is for those corner cases where I want to reply to only the list but the list is in the Cc: or something - this is rare)

Some food for thought. How many people think adding all these options to all e-mail clients is a good idea? :)

Signature · 2 lines
Infinite complexity begets infinite beauty.
Infinite precision begets infinite perfection.
#11 lore raw
In reply to Pascal Terjan
Quoted 9 lines · Pascal Terjan
Quoted 2 lines · John Davidorff Pell

P.S. Why does the list set the reply-to header, isn't that supposed to be a Bad Thing??

Only according to some people :)
I hate when I reply to a list and the message goes to the guy and not to the list... (If someone enforces Reply-To in his mail I think however that it should remain).

Thats the fault of a badly configured mail client.

I personally dislike Reply-To mailing lists, but I fixed my mail client (mutt) so it doesn't matter as much.

The reason I dislike Reply-To mailing lists - it is generally better to accidently send a list mail to one person than to send a one-person mail to the list. (But again I fixed my client so this doesn't affect me so much.)

Signature · 2 lines
Infinite complexity begets infinite beauty.
Infinite precision begets infinite perfection.
#12 lore raw
In reply to John Davidorff Pell
Quoted 3 lines · John Davidorff Pell

I was just thinking that by enabling the required feature individually, someone else could choose -O0 and not have to investigate why it fails. Its not like its a big deal, though. :-)

Like most things dyngen relies on this isn't a feature as such. There's no gcc option that says "make sure this function doesn't have a stack frame". It just happens that at with optimisation turned on this is generally true.

Also, the gcc -O2 option is more than the sum of the other options it enables.

Paul

#13 lore raw
Quoted 1 line · Paul Brook

Also, the gcc -O2 option is more than the sum of the other options it enables.

That, IMHO, is a bug. Of course, its not Qemu's bug. :-)

JP

--
"The New York Times is read by the people who run the country. The Washington Post is read by the people who think they run the country. The National Enquirer is read by the people who think Elvis is alive and running the country ..." -- Robert J Woodhead

#14 lore raw
In reply to Thiemo Seufer
Quoted 2 lines · Thiemo Seufer

Updated version, note that this is still not suitable for CVS since x86 fails to build with it.

fyi: for me, arm-softmmu fails as well:

.../qemu/qemu-snapshot-2006-03-30_23/target-arm/op.c
gcc: unrecognized option '-preferred-stack-boundary=2' /qemu/qemu-snapshot-2006-03-30_23/target-arm/op_mem.h: In function ‘op_vfp_std_kernel’:
/qemu/qemu-snapshot-2006-03-30_23/target-arm/op_mem.h:66:
error: unable to find a register to spill in class ‘GENERAL_REGS’ /qemu/qemu-snapshot-2006-03-30_23/target-arm/op_mem.h:66:
error: this is the insn:
(insn:HI 44 43 45 2 /qemu/qemu-snapshot-2006-03-30_23/cpu-all.h:342 (set (mem:DI (plus:SI (reg/v:SI 59 [ addr ])

                (reg:SI 73 [ <variable>.addend ])) [0 S8 A64])
        (reg:DI 63 [ <variable>.vfp.tmp0d ])) 57 {*movdi_2}
(insn_list:REG_DEP_TRUE 43 (nil))
    (expr_list:REG_DEAD (reg:DI 63 [ <variable>.vfp.tmp0d ])
        (expr_list:REG_DEAD (reg/v:SI 59 [ addr ])
            (expr_list:REG_DEAD (reg:SI 73 [
<variable>.addend ])
                (nil)))))

/qemu/qemu-snapshot-2006-03-30_23/target-arm/op_mem.h:66:
confused by earlier errors, bailing out
make[1]: *** [op.o] Error 1
make[1]: Leaving directory `/qemu/qemu-snapshot-2006-03-30_23/arm-softmmu'
make: *** [all] Error 1

Quoted 1 line

gcc -v

...
gcc version 4.0.2 20050901 (prerelease) (SUSE Linux)

Dirk

#15 lore raw
Quoted 6 lines · Dirk Behme
Quoted 2 lines · Thiemo Seufer

Updated version, note that this is still not suitable for CVS since x86 fails to build with it.

fyi: for me, arm-softmmu fails as well:

By x86, he probably means x86 hosts, not x86-softmmu

All targets (softmmu and user) would fail on x86 hosts. And possibly other hosts as well.

Quoted 2 lines

Dirk

Signature · 2 lines
Infinite complexity begets infinite beauty.
Infinite precision begets infinite perfection.