Skip to contentSkip to conversation

md: Introduction - assorted fixed for 2.6.16

PATCH New NeilBrown 2 participants 6 messages Mar 30, 2006 MD RAID

lore
Share & tools
lore

NeilBrown

author
#0 lore raw

PATCH 1/1 md: Introduction - assorted fixed for 2.6.16

Following are three patches for md. The first fixes a problem that can cause corruption in fairly unusual circumstances (re-adding a device to a raid1 and suffering write-errors that are subsequntly fixed and the device is re-added again).

The other two fix minor problems

The are suitable to go straight in to 2.6.17-rc.

NeilBrown

[PATCH 001 of 3] md: Don't clear bits in bitmap when writing to one device fails during recovery. [PATCH 002 of 3] md: Remove some code that can sleep from under a spinlock. [PATCH 003 of 3] md: Raid-6 did not create sysfs entries for stripe cache

author
#1 lore raw

PATCH 1/1 md: Don't clear bits in bitmap when writing to one device fails during recovery.

Currently a device failure during recovery leaves bits set in the bitmap. This normally isn't a problem as the offending device will be rejected because of errors. However if device re-adding is being used with non-persistent bitmaps, this can be a problem.

### Diffstat output

 ./drivers/md/raid1.c |   13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)
drivers/md/raid1.c renamed from drivers/md/raid1.c~current~ +12 -1
diff ./drivers/md/raid1.c~current~ ./drivers/md/raid1.c
@@ -1135,8 +1135,19 @@ static int end_sync_write(struct bio *bi
 			mirror = i;
 			break;
 		}
-	if (!uptodate)
+	if (!uptodate) {
+		int sync_blocks = 0;
+		sector_t s = r1_bio->sector;
+		long sectors_to_go = r1_bio->sectors;
+		/* make sure these bits doesn't get cleared. */
+		do {
+			bitmap_end_sync(mddev->bitmap, r1_bio->sector,
+					&sync_blocks, 1);
+			s += sync_blocks;
+			sectors_to_go -= sync_blocks;
+		} while (sectors_to_go > 0);
 		md_error(mddev, conf->mirrors[mirror].rdev);
+	}
 
 	update_head_pos(mirror, r1_bio);
 
#2 lore raw

Re: [PATCH 001 of 3] md: Don't clear bits in bitmap when writing to one device fails during recovery.

Quoted 4 lines · NeilBrown
(quoted diff) +1 -0
+	if (!uptodate) {
 +		int sync_blocks = 0;
 +		sector_t s = r1_bio->sector;

Review

Quoted 10 lines
(quoted diff) +0 -0
 +		long sectors_to_go = r1_bio->sectors;
 +		/* make sure these bits doesn't get cleared. */
 +		do {
 +			bitmap_end_sync(mddev->bitmap, r1_bio->sector,
 +					&sync_blocks, 1);
 +			s += sync_blocks;
 +			sectors_to_go -= sync_blocks;
 +		} while (sectors_to_go > 0);
  		md_error(mddev, conf->mirrors[mirror].rdev);
 +	}

Can mddev->bitmap be NULL?

If so, will the above loop do the right thing when this:

void bitmap_end_sync(struct bitmap *bitmap, sector_t offset, int *blocks, int aborted)

{
	bitmap_counter_t *bmc;
	unsigned long flags;
/*
	if (offset == 0) printk("bitmap_end_sync 0 (%d)\n", aborted);
*/	if (bitmap == NULL) {
		*blocks = 1024;
		return;
	}

triggers?

author
#3 lore raw

Re: [PATCH 001 of 3] md: Don't clear bits in bitmap when writing to one device fails during recovery.

Quoted 17 lines · On Wednesday March 29, [email protected] wrote:
Quoted 4 lines · NeilBrown
(quoted diff) +1 -0
+	if (!uptodate) {
 +		int sync_blocks = 0;
 +		sector_t s = r1_bio->sector;

Review

Quoted 10 lines
(quoted diff) +0 -0
 +		long sectors_to_go = r1_bio->sectors;
 +		/* make sure these bits doesn't get cleared. */
 +		do {
 +			bitmap_end_sync(mddev->bitmap, r1_bio->sector,
 +					&sync_blocks, 1);
 +			s += sync_blocks;
 +			sectors_to_go -= sync_blocks;
 +		} while (sectors_to_go > 0);
  		md_error(mddev, conf->mirrors[mirror].rdev);
 +	}

Can mddev->bitmap be NULL?

Yes, normally it is.

Quoted 14 lines

If so, will the above loop do the right thing when this:

void bitmap_end_sync(struct bitmap *bitmap, sector_t offset, int *blocks, int aborted)

{
	bitmap_counter_t *bmc;
	unsigned long flags;
/*
	if (offset == 0) printk("bitmap_end_sync 0 (%d)\n", aborted);
*/	if (bitmap == NULL) {
		*blocks = 1024;
		return;
	}
Quoted 1 line

triggers?

Yes. sync_blocks will be 1024 (a nice big number) and the loop will exit quite quickly having done nothing (which is what it needs to do in that case).
Ofcourse, if someone submits a bio for multiple thousands of sectors it will loop needlessly a few times, but do we ever generate bios that are even close to a megabyte?
If so, that 1024 can be safely increased to 1<<20, and possibly higher but I would need to check.

Thanks for asking
NeilBrown

author
#4 lore raw

PATCH 1/1 md: Remove some code that can sleep from under a spinlock.

In reply to NeilBrown

And remove the comments that were put in inplace of a fix too....

### Diffstat output

 ./drivers/md/md.c |    8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)
drivers/md/md.c renamed from drivers/md/md.c~current~ +3 -5
diff ./drivers/md/md.c~current~ ./drivers/md/md.c
@@ -214,13 +214,11 @@ static void mddev_put(mddev_t *mddev)
 		return;
 	if (!mddev->raid_disks && list_empty(&mddev->disks)) {
 		list_del(&mddev->all_mddevs);
-		/* that blocks */
+		spin_unlock(&all_mddevs_lock);
 		blk_cleanup_queue(mddev->queue);
-		/* that also blocks */
 		kobject_unregister(&mddev->kobj);
-		/* result blows... */
-	}
-	spin_unlock(&all_mddevs_lock);
+	} else
+		spin_unlock(&all_mddevs_lock);
 }
 
 static mddev_t * mddev_find(dev_t unit)
author
#5 lore raw

PATCH 1/1 md: Raid-6 did not create sysfs entries for stripe cache

In reply to NeilBrown

### Diffstat output

 ./drivers/md/raid6main.c |    2 ++
 1 file changed, 2 insertions(+)
drivers/md/raid6main.c renamed from drivers/md/raid6main.c~current~ +2 -0
diff ./drivers/md/raid6main.c~current~ ./drivers/md/raid6main.c
@@ -2151,6 +2151,8 @@ static int run(mddev_t *mddev)
 	}
 
 	/* Ok, everything is just fine now */
+	sysfs_create_group(&mddev->kobj, &raid6_attrs_group);
+
 	mddev->array_size =  mddev->size * (mddev->raid_disks - 2);
 
 	mddev->queue->unplug_fn = raid6_unplug_device;