splice exports
PATCH 1/1 splice exports
Woe be unto he who builds their filesystems as modules.
fs/splice.c +4 -0
@@ -22,6 +22,7 @@#include <linux/pipe_fs_i.h> #include <linux/mm_inline.h> #include <linux/swap.h> +#include <linux/module.h> /* * Passed to the actors
@@ -567,6 +568,9 @@ ssize_t generic_splice_sendpage(struct ireturn move_from_pipe (inode, out, len, flags, pipe_to_sendpage); } +EXPORT_SYMBOL (generic_file_splice_write); +EXPORT_SYMBOL (generic_file_splice_read); +static long do_splice_from (struct inode *pipe,struct file *out,size_t len,unsigned int flags) {
Quoted 18 lines · Jeff Garzik
Woe be unto he who builds their filesystems as modules.
Signed-off-by Jeff Garzik <[email protected]>fs/splice.c +1
-0@@ -22,6 +22,7 @@#include <linux/pipe_fs_i.h> #include <linux/mm_inline.h> #include <linux/swap.h> +#include <linux/module.h> /* * Passed to the actors
fs/splice.c ssize_t generic_splice_sendpage(struct i · line 576
Quoted 9 lines
fs/splice.c +3
-0@@ -567,6 +568,9 @@ ssize_t generic_splice_sendpage(struct ireturn move_from_pipe (inode, out, len, flags, pipe_to_sendpage); } +EXPORT_SYMBOL (generic_file_splice_write); +EXPORT_SYMBOL (generic_file_splice_read); +static long do_splice_from (struct inode *pipe,struct file *out,size_t len,unsigned int flags) {
Thanks Jeff!
Signature · 1 line
Jens Axboe
Quoted 1 line · Jeff Garzik
Woe be unto he who builds their filesystems as modules.
since splice support is highly linux specific and new.. shouldn't these be _GPL exports?
Quoted 6 lines · Arjan van de Ven
Quoted 1 line · Jeff Garzik
Woe be unto he who builds their filesystems as modules.
since splice support is highly linux specific and new.. shouldn't these be
_GPLexports?
Yes they should, I'll add that to the current splice tree.
Signature · 1 line
Jens Axboe
Quoted 8 lines · Jens Axboe
Quoted 5 lines · Arjan van de Ven
Quoted 1 line · Jeff Garzik
Woe be unto he who builds their filesystems as modules.
since splice support is highly linux specific and new.. shouldn't these be
_GPLexports?Yes they should, I'll add that to the current splice tree.
Why? We don't usually restrict filesystems in such ways... I would rather a binary-only module reference generic_file_splice_read() than create its own.
Jeff
Quoted 5 lines · Jeff Garzik
Quoted 4 lines · Jens Axboe
Quoted 3 lines · Arjan van de Ven
Quoted 1 line · Jeff Garzik
Woe be unto he who builds their filesystems as modules.
Quoted 8 lines
Quoted 4 lines
Quoted 2 lines
since splice support is highly linux specific and new.. shouldn't these be
_GPLexports?Yes they should, I'll add that to the current splice tree.
Why? We don't usually restrict filesystems in such ways... I would rather a binary-only module reference
generic_file_splice_read()than create its own.
You could use that very same argument for any piece of the kernel, then, so I don't think that adds much value to _not_ exporting it GPL.
Signature · 1 line
Jens Axboe
Quoted 4 lines · Jens Axboe
Quoted 3 lines · Jeff Garzik
Quoted 2 lines · Jens Axboe
Quoted 1 line · Arjan van de Ven
On Thu, 2006-03-30 at 23:06 -0500, Jeff Garzik wrote:
Quoted 8 lines
Quoted 5 lines
Quoted 4 lines
Quoted 3 lines
Quoted 1 line
Woe be unto he who builds their filesystems as modules.
since splice support is highly linux specific and new.. shouldn't these be
_GPLexports?Yes they should, I'll add that to the current splice tree.
Why? We don't usually restrict filesystems in such ways... I would rather a binary-only module reference
generic_file_splice_read()than create its own.You could use that very same argument for any piece of the kernel, then, so I don't think that adds much value to _not_ exporting it GPL.
Not really, because I'm considering the Real World(tm) users, not abstract theory :) The other filesystem junk is exported non-GPL, and existing binary-only filesystems use that stuff.
IOW its a bit rude to say "oh you can have your BO filesystem, just not splice support."
Jeff
Quoted 16 lines · Jeff Garzik
Quoted 7 lines · Jens Axboe
Quoted 6 lines · Jeff Garzik
Quoted 5 lines · Jens Axboe
Quoted 4 lines · Arjan van de Ven
Quoted 1 line · Jeff Garzik
Woe be unto he who builds their filesystems as modules.
since splice support is highly linux specific and new.. shouldn't these be
_GPLexports?Quoted 7 lines
Quoted 4 lines
Quoted 1 line
Yes they should, I'll add that to the current splice tree.
Why? We don't usually restrict filesystems in such ways... I would rather a binary-only module reference
generic_file_splice_read()than create its own.You could use that very same argument for any piece of the kernel, then, so I don't think that adds much value to _not_ exporting it GPL.
Quoted 6 lines
Not really, because I'm considering the Real World(tm) users, not abstract theory :) The other filesystem junk is exported non-GPL, and existing binary-only filesystems use that stuff.
IOW its a bit rude to say "oh you can have your BO filesystem, just not splice support."
it's a bit like saying "you can use all the standard unix interfaces, but these are very linux specific"; eg the same arguments for making lsm and other pieces _GPL; they're so linux specific that users that use these do so with linux in mind etc
Quoted 21 lines · Arjan van de Ven
Quoted 20 lines · Jeff Garzik
Quoted 7 lines · Jens Axboe
Quoted 6 lines · Jeff Garzik
Quoted 5 lines · Jens Axboe
Quoted 4 lines · Arjan van de Ven
Quoted 1 line · Jeff Garzik
Woe be unto he who builds their filesystems as modules.
since splice support is highly linux specific and new.. shouldn't these be
_GPLexports?Quoted 7 lines
Quoted 4 lines
Quoted 1 line
Yes they should, I'll add that to the current splice tree.
Why? We don't usually restrict filesystems in such ways... I would rather a binary-only module reference
generic_file_splice_read()than create its own.You could use that very same argument for any piece of the kernel, then, so I don't think that adds much value to _not_ exporting it GPL.
Not really, because I'm considering the Real World(tm) users, not abstract theory :) The other filesystem junk is exported non-GPL, and existing binary-only filesystems use that stuff.
Quoted 8 lines
Quoted 2 lines
IOW its a bit rude to say "oh you can have your BO filesystem, just not splice support."
it's a bit like saying "you can use all the standard unix interfaces, but these are very linux specific"; eg the same arguments for making lsm and other pieces
_GPL; they're so linux specific that users that use these do so with linux in mind etc
Linus seems to agree with the _GPL not being appropriate as well, so I guess I'll bow to the majority. This time :-)
Signature · 1 line
Jens Axboe
On Thu, Mar 30, 2006 at 11:06:13PM -0500, Jeff Garzik wrote:
/*
fs/splice.c ssize_t generic_splice_sendpage(struct i · line 572
Quoted 7 lines
* Passed to the actors
fs/splice.c +2
-0@@ -567,6 +568,9 @@ ssize_t generic_splice_sendpage(struct ireturn move_from_pipe (inode, out, len, flags, pipe_to_sendpage); } +EXPORT_SYMBOL (generic_file_splice_write); +EXPORT_SYMBOL (generic_file_splice_read);
Can we please have them right after the closing brace of the function defining these function instead.
Sam
Quoted 11 lines · Sam Ravnborg
On Thu, Mar 30, 2006 at 11:06:13PM -0500, Jeff Garzik wrote:
/*fs/splice.c ssize_t generic_splice_sendpage(struct i · line 572
Quoted 7 lines
* Passed to the actors
fs/splice.c +2
-0@@ -567,6 +568,9 @@ ssize_t generic_splice_sendpage(struct ireturn move_from_pipe (inode, out, len, flags, pipe_to_sendpage); } +EXPORT_SYMBOL (generic_file_splice_write); +EXPORT_SYMBOL (generic_file_splice_read);Can we please have them right after the closing brace of the function defining these function instead.
Signature · 1 line
Jens Axboe