Skip to contentSkip to conversation

ata_piix: fix ich6/m_map_db

PATCH Applied Tejun Heo 2 participants 2 messages Mar 31, 2006

Subsystems (2)
lore
Share & tools
lore

Tejun Heo

author
#0 lore raw

PATCH 1/1 ata_piix: fix ich6/m_map_db

MAP tables of ich6 and ich6m are wrong. Depending on port usage, ata_piix may fail to initialize attached devices.

---

Jeff, this one is critical. I compiled all port allocation tables correctly on my notebook, yet I succeeded to screw up. Dang. Sorry about the trouble.

 ata_piix.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/scsi/ata_piix.c +2 -2
Index: work/drivers/scsi/ata_piix.c
===================================================================
@@ -301,7 +301,7 @@ static struct piix_map_db ich6_map_db = 
 	.mask = 0x3,
 	.map = {
 		/* PM   PS   SM   SS       MAP */
-		{  P0,  P1,  P2,  P3 }, /* 00b */
+		{  P0,  P2,  P1,  P3 }, /* 00b */
 		{ IDE, IDE,  P1,  P3 }, /* 01b */
 		{  P0,  P2, IDE, IDE }, /* 10b */
 		{  RV,  RV,  RV,  RV },
@@ -312,7 +312,7 @@ static struct piix_map_db ich6m_map_db =
 	.mask = 0x3,
 	.map = {
 		/* PM   PS   SM   SS       MAP */
-		{  P0,  P1,  P2,  P3 }, /* 00b */
+		{  P0,  P2,  RV,  RV }, /* 00b */
 		{  RV,  RV,  RV,  RV },
 		{  P0,  P2, IDE, IDE }, /* 10b */
 		{  RV,  RV,  RV,  RV },
Applied
#1 lore raw
Quoted 4 lines · Tejun Heo

MAP tables of ich6 and ich6m are wrong. Depending on port usage, ata_piix may fail to initialize attached devices.

applied... this may fix some reported regressions.