Skip to contentSkip to conversation

acpi_os_wait_semaphore(): don't complain about timeout

PATCH Bjorn Helgaas 1 participant 1 message Mar 31, 2006 ACPI

lore
Share & tools
lore
#0 lore raw

The ASL Acquire operator (17.5.1 in ACPI 3.0 spec) is allowed to time out and return True without acquiring the semaphore. There's no indication in the spec that this is an actual error, so this message should be debug-only, as the message for successful acquisition is.

This used to be an ACPI_DEBUG_PRINT, but it was mis-classified as ACPI_DB_ERROR rather than ACPI_DB_MUTEX, so it got swept up in Thomas' recent patch to enable ACPI error messages even without CONFIG_ACPI_DEBUG.

drivers/acpi/osl.c +1 -1
Index: work-mm5/drivers/acpi/osl.c
===================================================================
@@ -816,7 +816,7 @@
 	}
 
 	if (ACPI_FAILURE(status)) {
-		ACPI_EXCEPTION((AE_INFO, status,
+		ACPI_DEBUG_PRINT((ACPI_DB_MUTEX,
 				  "Failed to acquire semaphore[%p|%d|%d], %s",
 				  handle, units, timeout,
 				  acpi_format_exception(status)));