Skip to contentSkip to conversation

s390: Wrong return codes in cio_ignore_proc_init().

PATCH New Martin Schwidefsky 1 participant 1 message Apr 3, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 4/9 s390: Wrong return codes in cio_ignore_proc_init().

From: Cornelia Huck <[email protected]>

[patch 4/9] s390: Wrong return codes in cio_ignore_proc_init().

cio_ignore_proc_init() returns 1 in case of success and 0 in case of failure. The caller tests for != 0, so better return 0 in case of success and -ENOENT in case of failure.

---

 drivers/s390/cio/blacklist.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/s390/cio/blacklist.c +2 -2
diff -urpN linux-2.6/drivers/s390/cio/blacklist.c linux-2.6-patched/drivers/s390/cio/blacklist.c
@@ -414,11 +414,11 @@ cio_ignore_proc_init (void)
 	entry = create_proc_entry ("cio_ignore", S_IFREG | S_IRUGO | S_IWUSR,
 				   &proc_root);
 	if (!entry)
-		return 0;
+		return -ENOENT;
 
 	entry->proc_fops = &cio_ignore_proc_fops;
 
-	return 1;
+	return 0;
 }
 
 __initcall (cio_ignore_proc_init);