Skip to contentSkip to conversation

Fix return value of ext2load

PATCH New ito at mlb.co.jp 1 participant 2 messages Apr 4, 2006 ext2 file system

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix return value of ext2load

Hello

I like to do

if ext2load ide 0 80400000 $bootfile; then bootm; fi

but the return value of ext2load is always false.

Please consider to merge.
Patch is attched.
--------
Hiroshi Ito
Media Lab. Inc.,
URL http://www.mlb.co.jp ( Sorry, Japanese only. ) TEL +81-3-5294-7255 FAX +81-3-5294-7256 -------------- next part --------------

fs/ext2/ext2fs.c +2 -2
index 9cf2fb7..069f8ae 100644
@@ -769,7 +769,7 @@ int ext2fs_open (char *filename) {
 	int len;
 
 	if (ext2fs_root == NULL) {
-		return (-1);
+		return (0);
 	}
 	ext2fs_file = NULL;
 	status = ext2fs_find_file (filename, &ext2fs_root->diropen, &fdiro,
@@ -786,7 +786,7 @@ int ext2fs_open (char *filename) {
 	}
 	len = __le32_to_cpu (fdiro->inode.size);
 	ext2fs_file = fdiro;
-	return (len);
+	return (0);
 
 fail:
 	ext2fs_free_node (fdiro, &ext2fs_root->diropen);
#1 lore raw

PATCH 1/1 Fix return value of ext2load

Sorry, I attached wrong patch.
it should not apply.

Here is a correct patch.
--------
Hiroshi Ito
Media Lab. Inc.,
URL http://www.mlb.co.jp ( Sorry, Japanese only. ) TEL +81-3-5294-7255 FAX +81-3-5294-7256

From: [email protected]
Subject: [U-Boot-Users] [PATCH] Fix return value of ext2load
Date: Tue, 04 Apr 2006 16:05:45 +0900 (JST)
Message-Id: <[email protected]>

Quoted 8 lines

Hello

I like to do

if ext2load ide 0 80400000 $bootfile; then bootm; fi

but the return value of ext2load is always false.

Quoted 7 lines

Please consider to merge.
Patch is attched.
--------
Hiroshi Ito
Media Lab. Inc.,
URL http://www.mlb.co.jp ( Sorry, Japanese only. ) TEL +81-3-5294-7255 FAX +81-3-5294-7256

-------------- next part --------------

common/cmd_ext2.c +1 -1
index 5db42f2..36b0678 100644
@@ -283,7 +283,7 @@ int do_ext2load (cmd_tbl_t *cmdtp, int f
 	sprintf(buf, "%lX", filelen);
 	setenv("filesize", buf);
 
-	return(filelen);
+	return(0);
 }
 
 U_BOOT_CMD(