Remove blkmtd
Subsystems (2)
cover Remove blkmtd
This patchset removed blkmtd in three steps:
1. Mark it as deprecated,
2. mark block2mtd, the replacement, as no longer experimental and
3. remove the driver.
Eric suggested sending patch 1 and 2 directly to Linus while leaving patch 3 in -mm as long as klibc remains there as well. Andrew, do you prefer me to send the first two patches to Linus or will you rather do it yourself?
Jörn
Signature · 3 lines
When people work hard for you for a pat on the back, you've got to give them that pat. -- Robert Heinlein
PATCH 1/3 Immediatly deprecate blkmtd
Deprecate blkmtd. Reasoning is described in the patch itself.
---
Documentation/feature-removal-schedule.txt | 14 ++++++++++++++ 1 file changed, 14 insertions(+)
Documentation/feature-removal-schedule.txt renamed from Documentation/feature-removal-schedule.txt~blkmtd_deprecation +14 -0
@@ -246,3 +246,17 @@ Why: The interface no longer has any cal Who: Nick Piggin <[email protected]> --------------------------- + +What: blkmtd +When: April 2006 +Files: drivers/mtd/devices/blkmtd.c +Why: o An alternative exists that hasn't had bug report for > 1 year. + o Most embedded people tend to use ancient kernels with custom patches + from mtd cvs and elsewhere, so the 1 year warning period neither + helps nor hurts them too much. + o It's in the way of klibc. The problems caused by pulling blkmtd + support are fairly low, while the problems caused by delaying klibc + can be fairly substantial. At best, this would be a severe burden + on hpa's time. + +Who: Joern Engel <[email protected]>
Re: [Patch 1/3] Immediatly deprecate blkmtd
Quoted 3 lines · Jörn Engel
Deprecate blkmtd. Reasoning is described in the patch itself.
Signed-off-by Jörn Engel <[email protected]>
PATCH 2/3 Mark block2mtd as not deprecated
In reply to Jörn EngelThe last (and only) bugreport for this driver was > 1 year ago. There is no reason to mark it as experimental anymore.
---
drivers/mtd/devices/Kconfig | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/mtd/devices/Kconfig renamed from drivers/mtd/devices/Kconfig~block2mtd_experimental +2 -4
@@ -143,12 +143,10 @@ config MTD_BLKMTD config MTD_BLOCK2MTD tristate "MTD using block device (rewrite)" - depends on MTD && EXPERIMENTAL + depends on MTD help This driver is basically the same at MTD_BLKMTD above, but - experienced some interface changes plus serious speedups. In - the long term, it should replace MTD_BLKMTD. Right now, you - shouldn't entrust important data to it yet. + experienced some interface changes plus serious speedups. comment "Disk-On-Chip Device Drivers"
Re: [Patch 2/3] Mark block2mtd as not deprecated
Quoted 4 lines · Jörn Engel
The last (and only) bugreport for this driver was > 1 year ago. There is no reason to mark it as experimental anymore.
Signed-off-by Jörn Engel <[email protected]>
Re: [Patch 2/3] Mark block2mtd as not deprecated
In reply to Jörn EngelQuoted 1 line · Jörn Engel
Subject: [Patch 2/3] Mark block2mtd as not deprecated
^^^^^^^^^^
Lack of coffee. That should have been "experimental".
Jörn
Signature · 3 lines
Das Aufregende am Schreiben ist es, eine Ordnung zu schaffen, wo vorher keine existiert hat. -- Doris Lessing
PATCH 3/3 Remove blkmtd
In reply to Jörn Engelo Remove the (very recently) deprecated blkmtd driver.
o Move the Kconfig description over to block2mtd, its replacement.
---
Documentation/feature-removal-schedule.txt | 16 drivers/mtd/devices/Kconfig | 11 drivers/mtd/devices/Makefile | 1 drivers/mtd/devices/blkmtd.c~blkmtd_removal | 819 ---------------------------- 4 files changed, 2 insertions(+), 845 deletions(-)
Documentation/feature-removal-schedule.txt renamed from Documentation/feature-removal-schedule.txt~blkmtd_removal +0 -16
@@ -244,19 +244,3 @@ Why: The interface no longer has any cal This feature removal can be reevaluated if users of the interface cannot cleanly use something else. Who: Nick Piggin <[email protected]> - ---------------------------- - -What: blkmtd -When: April 2006 -Files: drivers/mtd/devices/blkmtd.c -Why: o An alternative exists that hasn't had bug report for > 1 year. - o Most embedded people tend to use ancient kernels with custom patches - from mtd cvs and elsewhere, so the 1 year warning period neither - helps nor hurts them too much. - o It's in the way of klibc. The problems caused by pulling blkmtd - support are fairly low, while the problems caused by delaying klibc - can be fairly substantial. At best, this would be a severe burden - on hpa's time. - -Who: Joern Engel <[email protected]>
drivers/mtd/devices/Kconfig renamed from drivers/mtd/devices/Kconfig~blkmtd_removal +2 -9
@@ -129,8 +129,8 @@ config MTDRAM_ABS_POS allocating space from Linux's available memory. Otherwise, leave this set to zero. Most people will want to leave this as zero. -config MTD_BLKMTD - tristate "MTD emulation using block device" +config MTD_BLOCK2MTD + tristate "MTD using block device" depends on MTD help This driver allows a block device to appear as an MTD. It would
@@ -141,13 +141,6 @@ config MTD_BLKMTD Testing MTD users (eg JFFS2) on large media and media that might be removed during a write (using the floppy drive). -config MTD_BLOCK2MTD - tristate "MTD using block device (rewrite)" - depends on MTD - help - This driver is basically the same at MTD_BLKMTD above, but - experienced some interface changes plus serious speedups. - comment "Disk-On-Chip Device Drivers" config MTD_DOC2000
drivers/mtd/devices/Makefile renamed from drivers/mtd/devices/Makefile~blkmtd_removal +0 -1
@@ -21,7 +21,6 @@ obj-$(CONFIG_MTD_PMC551) += pmc551.o obj-$(CONFIG_MTD_MS02NV) += ms02-nv.o obj-$(CONFIG_MTD_MTDRAM) += mtdram.o obj-$(CONFIG_MTD_LART) += lart.o -obj-$(CONFIG_MTD_BLKMTD) += blkmtd.o obj-$(CONFIG_MTD_BLOCK2MTD) += block2mtd.o obj-$(CONFIG_MTD_DATAFLASH) += mtd_dataflash.o obj-$(CONFIG_MTD_M25P80) += m25p80.o
drivers/mtd/devices/blkmtd.c~blkmtd_removal deleted +0 -819
819 lines not on this page · raw message
Quoted 4 lines · Jörn Engel
o Remove the (very recently) deprecated blkmtd driver.
o Move theKconfigdescription over to block2mtd, its replacement.Signed-off-by Jörn Engel <[email protected]
Quoted 11 lines · Jörn Engel
This patchset removed blkmtd in three steps:
1. Mark it as deprecated,
2. mark block2mtd, the replacement, as no longer experimental and
3. remove the driver.Eric suggested sending patch 1 and 2 directly to Linus while leaving patch 3 in -mm as long as klibc remains there as well. Andrew, do you prefer me to send the first two patches to Linus or will you rather do it yourself?
That's all too much fuss. Let's just zap it.