Skip to contentSkip to conversation

CONFIG_SKIP_LOWLEVEL_INIT is broken for at91rm9200dk

U-Boot-Users Wang Jian 5 participants 9 messages Apr 3, 2006 – Apr 4, 2006

lore
Share & tools
lore

Wang Jian

author
#0 lore raw

Hi,

When CONFIG_SKIP_LOWLEVEL_INIT is defined, cpu/arm920t/at91rm9200/lowlevel_init.S is commented out and lowlevel_init() is undefined.

But cpu/arm920t/start.S will still use lowlevel_init(). See the code

--snip--
#ifndef CONFIG_SKIP_LOWLEVEL_INIT
bl cpu_init_crit
#endif
--snip--

but cpu_init_crit() is still defined and use lowlevel_init().

cpu/arm920t/start.o(.text+0xec):/home/lark/arm-u-boot.git/cpu/arm920t/start.S:264: undefined reference to `lowlevel_init'
make: *** [u-boot] Error 1

Signature · 1 line
  lark
#1 lore raw

Wang Jian ha scritto:

Quoted 13 lines

Hi,

When CONFIG_SKIP_LOWLEVEL_INIT is defined, cpu/arm920t/at91rm9200/lowlevel_init.S is commented out and lowlevel_init() is undefined.

But cpu/arm920t/start.S will still use lowlevel_init(). See the code

--snip--
#ifndef CONFIG_SKIP_LOWLEVEL_INIT
bl cpu_init_crit
#endif
--snip--

Quoted 5 lines

but cpu_init_crit() is still defined and use lowlevel_init().

cpu/arm920t/start.o(.text+0xec):/home/lark/arm-u-boot.git/cpu/arm920t/start.S:264: undefined reference to `lowlevel_init'
make: *** [u-boot] Error 1

Hi I noticed and solved this problem and all CONFIG_SKIP_LOWLEVEL_INIT related one for AT91 last week.
BTW I noticed that there is an existing patch [DNX#2006033142000856] to solve it too, but I don't know where is the u-boot patch repository.

Feel free to contact me if you want my own patch.

Best regards

Signature · 4 lines
Marco Cavallini
Koan s.a.s. - Bergamo - ITALIA
Embedded and Real-Time Software Engineering
www.koansoftware.com    |    www.klinux.org
#2 lore raw
In reply to Wang Jian
Quoted 13 lines · Wang Jian

Hi,

When CONFIG_SKIP_LOWLEVEL_INIT is defined, cpu/arm920t/at91rm9200/lowlevel_init.S is commented out and lowlevel_init() is undefined.

But cpu/arm920t/start.S will still use lowlevel_init(). See the code

--snip--
#ifndef CONFIG_SKIP_LOWLEVEL_INIT
bl cpu_init_crit
#endif
--snip--

Quoted 8 lines

but cpu_init_crit() is still defined and use lowlevel_init().

cpu/arm920t/start.o(.text+0xec):/home/lark/arm-u-boot.git/cpu/arm920t/start.S:264: undefined reference to `lowlevel_init'
make: *** [u-boot] Error 1

Hi,
Here my patch (I do not find it in the mailing list archives for some reason...)

Best regards
Peter

CHANGELOG:
Patch by Peter Menzebach, 2005-10-13
ifdef CONFIG_SKIP_LOWLEVEL_INIT around
cpu_init_crit added in cpu/arm920t/start.S

cpu/arm920t/start.S renamed from cpu/arm920t/start.S.orig +2 -1
@@ -237,6 +237,7 @@
   */
 
 
+#ifndef CONFIG_SKIP_LOWLEVEL_INIT
  cpu_init_crit:
  	/*
  	 * flush v4 I/D caches
@@ -264,7 +265,7 @@
  	bl	lowlevel_init
  	mov	lr, ip
  	mov	pc, lr
-
+#endif /* CONFIG_SKIP_LOWLEVEL_INIT */
 
  /*
   *************************************************************************
#3 lore raw

Dear Peter,

Quoted 3 lines · in message <[email protected]> you wrote:

Here my patch (I do not find it in the mailing list archives for some reason...)

You patch, submitted as
10/13/05 Peter Menzebach [U-Boot-Users] [PATCH] trivial bugfix, #ifdef CONFIG_SKIP_LOWLEVEL_IN is registered as DNX#2006040142000473 in the patch database. You
should have received a confirmation message - did you?

Best regards,

Wolfgang Denk

Signature · 4 lines
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I have a theory that it's impossible to prove anything, but  I  can't
prove it.
#4 lore raw
Quoted 10 lines · Wolfgang Denk

Dear Peter,

Quoted 2 lines · in message <[email protected]> you wrote:

Here my patch (I do not find it in the mailing list archives for some reason...)

You patch, submitted as
10/13/05 Peter Menzebach [U-Boot-Users] [PATCH] trivial bugfix, #ifdef CONFIG_SKIP_LOWLEVEL_IN is registered as DNX#2006040142000473 in the patch database. You
should have received a confirmation message - did you?

Dear Wolfgang,
I now found the the confirmation according to the ticket ID, but my mailer did not succeed in correlating it to the original message (and you sent some more messages that time ;) ). My mailer often cannot correlate responses here on this mailing list. I think (not checked in detail), my mailer would like a Reference: field...

Best regards
Peter

#5 lore raw

Dear Peter,

Quoted 6 lines · in message <[email protected]> you wrote:

I now found the the confirmation according to the ticket ID, but my mailer did not succeed in correlating it to the original message (and you sent some more messages that time ;) ). My mailer often cannot correlate responses here on this mailing list. I think (not checked in detail), my mailer would like a Reference: field...

Your mailer is not to blame here. There probably was no useful reference field at all in these messages as you did not actually send this message, but rather it was me who bounced the whole batch of open patches. This is supposed to work better when you send a patch directly to u-boot-patches at denx.de

Best regards,

Wolfgang Denk

Signature · 4 lines
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I mean, I . . . think to understand you, I just don't know  what  you
are saying ...                        - Terry Pratchett, _Soul Music_
author
#6 lore raw
In reply to Peter Menzebach

Hi Peter Menzebach,

This is exactly what I had done locally, and it works. But I don't know if it is perfect or not (I am in a hurry)

Quoted 67 lines · Peter Menzebach
Quoted 13 lines · Wang Jian

Hi,

When CONFIG_SKIP_LOWLEVEL_INIT is defined, cpu/arm920t/at91rm9200/lowlevel_init.S is commented out and lowlevel_init() is undefined.

But cpu/arm920t/start.S will still use lowlevel_init(). See the code

--snip--
#ifndef CONFIG_SKIP_LOWLEVEL_INIT
bl cpu_init_crit
#endif
--snip--

Quoted 8 lines

but cpu_init_crit() is still defined and use lowlevel_init().

cpu/arm920t/start.o(.text+0xec):/home/lark/arm-u-boot.git/cpu/arm920t/start.S:264: undefined reference to `lowlevel_init'
make: *** [u-boot] Error 1

Hi,
Here my patch (I do not find it in the mailing list archives for some reason...)

Best regards
Peter

CHANGELOG:
Patch by Peter Menzebach, 2005-10-13
ifdef CONFIG_SKIP_LOWLEVEL_INIT around
cpu_init_crit added in cpu/arm920t/start.S

cpu/arm920t/start.S renamed from cpu/arm920t/start.S.orig +2 -2
@@ -237,6 +237,7 @@
   */
 
 
+#ifndef CONFIG_SKIP_LOWLEVEL_INIT
  cpu_init_crit:
  	/*
  	 * flush v4 I/D caches
@@ -264,7 +265,7 @@
  	bl	lowlevel_init
  	mov	lr, ip
  	mov	pc, lr
-
+#endif /* CONFIG_SKIP_LOWLEVEL_INIT */
 
  /*
   *************************************************************************
 
 
 
-------------------------------------------------------

This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
_______________________________________________
U-Boot-Users mailing list
U-Boot-Users at lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Signature · 1 line
  lark
#7 lore raw
Quoted 3 lines · In message <[email protected]> you wrote:

This is exactly what I had done locally, and it works. But I don't know if it is perfect or not (I am in a hurry)

"It works" is good enough. Patch applied. Thanks.

Best regards,

Wolfgang Denk

Signature · 5 lines
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Where humor is concerned there are no standards -- no  one  can  say
what is good or bad, although you can be sure that everyone will.
- John Kenneth Galbraith
#8 lore raw
In reply to Wang Jian

Hello,

I had the same problem :
(http://sourceforge.net/mailarchive/forum.php?thread_id=8236003&forum_id=12898)

Quoted 6 lines · Wang Jian

Hi Peter Menzebach,

This is exactly what I had done locally, and it works. But I don't know if it is perfect or not (I am in a hurry)

On Mon, 03 Apr 2006 12:01:54 +0200, Peter Menzebach <[email protected]>

Quoted 59 lines · wrote:
Quoted 59 lines
Quoted 14 lines · Wang Jian

Hi,

When CONFIG_SKIP_LOWLEVEL_INIT is defined, cpu/arm920t/at91rm9200/lowlevel_init.S is commented out and lowlevel_init() is undefined.

But cpu/arm920t/start.S will still use lowlevel_init(). See the code

--snip--
#ifndef CONFIG_SKIP_LOWLEVEL_INIT
bl cpu_init_crit
#endif
--snip--

Quoted 6 lines

but cpu_init_crit() is still defined and use lowlevel_init().

cpu/arm920t/start.o(.text+0xec):/home/lark/arm-u-boot.git/cpu/arm920t/s tart.S:264: undefined reference to `lowlevel_init' make: *** [u-boot] Error 1

Hi,
Here my patch (I do not find it in the mailing list archives for some reason...)

Best regards
Peter

CHANGELOG:
Patch by Peter Menzebach, 2005-10-13
ifdef CONFIG_SKIP_LOWLEVEL_INIT around
cpu_init_crit added in cpu/arm920t/start.S

cpu/arm920t/start.S renamed from cpu/arm920t/start.S.orig +2 -1
@@ -237,6 +237,7 @@
   */
 
 
+#ifndef CONFIG_SKIP_LOWLEVEL_INIT
  cpu_init_crit:
  	/*
  	 * flush v4 I/D caches
@@ -264,7 +265,7 @@
  	bl	lowlevel_init
  	mov	lr, ip
  	mov	pc, lr
-
+#endif /* CONFIG_SKIP_LOWLEVEL_INIT */
 
  /*
 

*************************************************************************

Quoted 10 lines
Quoted 10 lines

-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
_______________________________________________
U-Boot-Users mailing list
U-Boot-Users at lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

mathdesc