Skip to contentSkip to conversation

ISDN_DRV_GIGASET should select, not depend on CRC_CCITT

PATCH In review Adrian Bunk 2 participants 2 messages Apr 5, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ISDN_DRV_GIGASET should select, not depend on CRC_CCITT

CRC_CCITT is an internal helper function that should be select'ed.

drivers/isdn/gigaset/Kconfig renamed from drivers/isdn/gigaset/Kconfig.old +2 -1
@@ -3,7 +3,8 @@
 
 config ISDN_DRV_GIGASET
 	tristate "Siemens Gigaset support (isdn)"
-	depends on ISDN_I4L && CRC_CCITT
+	depends on ISDN_I4L
+	select CRC_CCITT
 	help
 	  Say m here if you have a Gigaset or Sinus isdn device.
 
Acked-by on v1 1/1
#1 lore raw
Quoted 1 line · Adrian Bunk

CRC_CCITT is an internal helper function that should be select'ed.

Good point. Thanks.

Quoted 1 line
Quoted 14 lines
drivers/isdn/gigaset/Kconfig renamed from drivers/isdn/gigaset/Kconfig.old +2 -1
@@ -3,7 +3,8 @@
 
 config ISDN_DRV_GIGASET
 	tristate "Siemens Gigaset support (isdn)"
-	depends on ISDN_I4L && CRC_CCITT
+	depends on ISDN_I4L
+	select CRC_CCITT
 	help
 	  Say m here if you have a Gigaset or Sinus isdn device.
 
Signature · 4 lines
Tilman Schmidt                          E-Mail: [email protected]
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)