ACPI Compile error in current git (pci.h)

DISCUSSION Nigel Cunningham 2 participants 4 messages Mar 24, 2006 – Apr 6, 2006 ACPI

lore

Share & tools

lore

Nigel Cunningham

author

2006-03-24 04:05 UTC #0 lore raw

Hi.

Current git produces the following compile error (x86_64 uniprocessor compile):

arch/x86_64/pci/mmconfig.c:152: error: conflicting types for ‘pci_mmcfg_init’ arch/i386/pci/pci.h:85: error: previous declaration of ‘pci_mmcfg_init’ was here make[1]: *** [arch/x86_64/pci/mmconfig.o] Error 1
make: *** [arch/x86_64/pci] Error 2

I haven't found out yet how the i386 file is getting included, but I can say that git compiled fine last night.

Greg, I believe you're the pci guru, so I thought I'd try you too. Apologies in advance if I've gotten it wrong.

Regards,

Nigel

Nigel Cunningham

author

2006-03-24 04:39 UTC #1 lore raw

Hi again.

Quoted 5 lines · Nigel Cunningham

Hi.
Current git produces the following compile error (x86_64 uniprocessor compile):

Quoted 7 lines

arch/x86_64/pci/mmconfig.c:152: error: conflicting types for ‘pci_mmcfg_init’ arch/i386/pci/pci.h:85: error: previous declaration of ‘pci_mmcfg_init’ was here make[1]: *** [arch/x86_64/pci/mmconfig.o] Error 1
make: *** [arch/x86_64/pci] Error 2
I haven't found out yet how the i386 file is getting included, but I can say that git compiled fine last night.

Got the answer to this bit - it is included via the Makefile in the directory setting a -I flag, and the file including "pci.h".

Regards,

Nigel

Greg KH

2006-04-06 03:55 UTC #2 lore raw

Quoted 13 lines · Nigel Cunningham

Hi again.
Quoted 10 lines · Nigel Cunningham
Hi.
Current git produces the following compile error (x86_64 uniprocessor compile):
arch/x86_64/pci/mmconfig.c:152: error: conflicting types for ???pci_mmcfg_init??? arch/i386/pci/pci.h:85: error: previous declaration of ???pci_mmcfg_init??? was here make[1]: *** [arch/x86_64/pci/mmconfig.o] Error 1
make: *** [arch/x86_64/pci] Error 2

Quoted 5 lines

Quoted 2 lines
I haven't found out yet how the i386 file is getting included, but I can say that git compiled fine last night.
Got the answer to this bit - it is included via the Makefile in the directory setting a -I flag, and the file including "pci.h".

Does this still happen for 2.6.17-rc1?

thanks,

greg k-h

Nigel Cunningham

author

2006-04-06 04:09 UTC #3 lore raw

Hi Greg.

Quoted 18 lines · Greg KH

Quoted 17 lines · Nigel Cunningham
Hi again.
Quoted 13 lines · Nigel Cunningham
Hi.
Current git produces the following compile error (x86_64 uniprocessor compile):
arch/x86_64/pci/mmconfig.c:152: error: conflicting types for ???pci_mmcfg_init??? arch/i386/pci/pci.h:85: error: previous declaration of ???pci_mmcfg_init??? was here make[1]: *** [arch/x86_64/pci/mmconfig.o] Error 1 make: *** [arch/x86_64/pci] Error 2
I haven't found out yet how the i386 file is getting included, but I can say that git compiled fine last night.

Quoted 8 lines

Quoted 2 lines
Got the answer to this bit - it is included via the Makefile in the directory setting a -I flag, and the file including "pci.h".
Does this still happen for 2.6.17-rc1?
thanks,
greg k-h

No, it's fixed. I figured out the cause a little later the same day, and so did someone else (don't recall the name now). A patch has been merged.

Regards,

Nigel