Skip to contentSkip to conversation

ipmi: fix event queue limit

PATCH New Corey Minyard 1 participant 1 message Apr 8, 2006 IPMI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ipmi: fix event queue limit

The event handler mechanism in the IPMI driver had a limit on the number of received events, but the counts were not being updated. Update the counts to impose a limit. This is not a critical fix, as this function (the sending of the events) has to be turned on by the user, anyway. This avoids problems if they forget to turn it back off.

drivers/char/ipmi/ipmi_msghandler.c +2 -0
Index: linux-2.6.16/drivers/char/ipmi/ipmi_msghandler.c
===================================================================
@@ -941,6 +941,7 @@ int ipmi_set_gets_events(ipmi_user_t use
 			list_del(&msg->link);
 			list_add_tail(&msg->link, &msgs);
 		}
+		intf->waiting_events_count = 0;
 	}
 
 	/* Hold the events lock while doing this to preserve order. */
@@ -2917,6 +2918,7 @@ static int handle_read_event_rsp(ipmi_sm
 
 		copy_event_into_recv_msg(recv_msg, msg);
 		list_add_tail(&(recv_msg->link), &(intf->waiting_events));
+		intf->waiting_events_count++;
 	} else {
 		/* There's too many things in the queue, discard this
 		   message. */