drivers/md/md.c: make md_print_devices() static
RFC PATCH 1/1 drivers/md/md.c: make md_print_devices() static
This patch makes the needlessly global md_print_devices() static.
Signed-off-by Adrian Bunk <[email protected]>
---
drivers/md/md.c | 7 +++++-- include/linux/raid/md.h | 4 ---- 2 files changed, 5 insertions(+), 6 deletions(-)
include/linux/raid/md.h renamed from include/linux/raid/md.h.old +0 -4
@@ -85,8 +85,6 @@extern void md_error (mddev_t *mddev,mdk_rdev_t *rdev);extern void md_unplug_mddev (mddev_t *mddev); -extern void md_print_devices (void ); -extern void md_super_write (mddev_t *mddev,mdk_rdev_t *rdev,sector_t sector,int size,struct page *page);extern void md_super_wait (mddev_t *mddev);
@@ -97,7 +95,5 @@extern void md_update_sb (mddev_t * mddev); -#define MD_BUG(x...) { printk("md: bug in file %s, line %d\n", __FILE__, __LINE__); md_print_devices(); } -#endif
drivers/md/md.c renamed from drivers/md/md.c.old +5 -2
@@ -72,6 +72,10 @@static LIST_HEAD (pers_list);static DEFINE_SPINLOCK (pers_lock); +static void md_print_devices (void ); + +#define MD_BUG(x...) { printk("md: bug in file %s, line %d\n", __FILE__, __LINE__); md_print_devices(); } +/* * Current RAID-1,4,5 parallel reconstruction 'guaranteed speed limit' * is 1000 KB/sec, so the extra system load does not show up that much.
@@ -1503,7 +1507,7 @@printk (KERN_INFO "md: no rdev superblock!\n" ); } -void md_print_devices (void ) +static void md_print_devices (void ) {struct list_head *tmp, *tmp2;mdk_rdev_t *rdev;
@@ -5205,7 +5209,6 @@EXPORT_SYMBOL (md_register_thread);EXPORT_SYMBOL (md_unregister_thread);EXPORT_SYMBOL (md_wakeup_thread); -EXPORT_SYMBOL (md_print_devices);EXPORT_SYMBOL (md_check_recovery);MODULE_LICENSE ("GPL" );MODULE_ALIAS ("md" );
Quoted 3 lines · On Tuesday April 11, [email protected] wrote:
This patch makes the needlessly global
md_print_devices()static.Signed-off-by Adrian Bunk <[email protected]>
Looks good, thanks. It'll be in my next batch to Andrew.
NeilBrown