Skip to contentSkip to conversation

only free_irq() after request_irq() succeeds

PATCH New Zach Brown 1 participant 1 message Apr 10, 2006

Subsystems (2)
lore
Share & tools
lore

Zach Brown

author
#0 lore raw

PATCH 1/1 only free_irq() after request_irq() succeeds

[qla2xxx] only free_irq() after request_irq() succeeds

If qla2x00_probe_one() fails before calling request_irq() but gets to qla2x00_free_device() then it will mistakenly tree to free an irq it didn't request. It's chosing to free based on ha->pdev->irq which is always set.

host->irq is set after request_irq() succeeds so let's use that to decide to free or not.

This was observed and tested when a silly set of circumstances lead to firmware loading failing on a 2100.

---

 drivers/scsi/qla2xxx/qla_os.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/scsi/qla2xxx/qla_os.c +2 -2
Index: 2.6.17-rc1-mm2-qlafreeirq/drivers/scsi/qla2xxx/qla_os.c
===================================================================
@@ -1700,8 +1700,8 @@ qla2x00_free_device(scsi_qla_host_t *ha)
 	ha->flags.online = 0;
 
 	/* Detach interrupts */
-	if (ha->pdev->irq)
-		free_irq(ha->pdev->irq, ha);
+	if (ha->host->irq)
+		free_irq(ha->host->irq, ha);
 
 	/* release io space registers  */
 	if (ha->iobase)