Skip to contentSkip to conversation

kernel/rcupdate.c: kill synchronize_kernel()

PATCH In review Adrian Bunk 3 participants 4 messages Apr 11, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kernel/rcupdate.c: kill synchronize_kernel()

synchronize_kernel() is both deprecated and completely unused.

Let's kill this bloat.

---

 Documentation/RCU/whatisRCU.txt |    1 -
 include/linux/rcupdate.h        |    1 -
 kernel/rcupdate.c               |    9 ---------
 3 files changed, 11 deletions(-)
Documentation/RCU/whatisRCU.txt renamed from Documentation/RCU/whatisRCU.txt.old +0 -1
@@ -790,7 +790,6 @@
 
 RCU grace period:
 
-	synchronize_kernel (deprecated)
 	synchronize_net
 	synchronize_sched
 	synchronize_rcu
include/linux/rcupdate.h renamed from include/linux/rcupdate.h.old +0 -1
@@ -263,7 +263,6 @@
 				void (*func)(struct rcu_head *head)));
 extern void FASTCALL(call_rcu_bh(struct rcu_head *head,
 				void (*func)(struct rcu_head *head)));
-extern __deprecated_for_modules void synchronize_kernel(void);
 extern void synchronize_rcu(void);
 void synchronize_idle(void);
 extern void rcu_barrier(void);
kernel/rcupdate.c renamed from kernel/rcupdate.c.old +0 -9
@@ -593,14 +593,6 @@
 	wait_for_completion(&rcu.completion);
 }
 
-/*
- * Deprecated, use synchronize_rcu() or synchronize_sched() instead.
- */
-void synchronize_kernel(void)
-{
-	synchronize_rcu();
-}
-
 module_param(blimit, int, 0);
 module_param(qhimark, int, 0);
 module_param(qlowmark, int, 0);
@@ -611,4 +603,3 @@
 EXPORT_SYMBOL_GPL_FUTURE(call_rcu);	/* WARNING: GPL-only in April 2006. */
 EXPORT_SYMBOL_GPL_FUTURE(call_rcu_bh);	/* WARNING: GPL-only in April 2006. */
 EXPORT_SYMBOL_GPL(synchronize_rcu);
-EXPORT_SYMBOL_GPL_FUTURE(synchronize_kernel); /* WARNING: GPL-only in April 2006. */
#1 lore raw

Hello, Adrian,

This one is on my list for May 1st. At that time, I will submit a patch such that:

o synchronize_kernel() goes away

o call_rcu() and call_rcu_bh() become EXPORT_SYMBOL_GPL().

Thanx, Paul

Quoted 56 lines · Adrian Bunk

synchronize_kernel() is both deprecated and completely unused.

Let's kill this bloat.

---

 Documentation/RCU/whatisRCU.txt |    1 -
 include/linux/rcupdate.h        |    1 -
 kernel/rcupdate.c               |    9 ---------
 3 files changed, 11 deletions(-)
Documentation/RCU/whatisRCU.txt renamed from Documentation/RCU/whatisRCU.txt.old +0 -1
@@ -790,7 +790,6 @@
 
 RCU grace period:
 
-	synchronize_kernel (deprecated)
 	synchronize_net
 	synchronize_sched
 	synchronize_rcu
include/linux/rcupdate.h renamed from include/linux/rcupdate.h.old +0 -1
@@ -263,7 +263,6 @@
 				void (*func)(struct rcu_head *head)));
 extern void FASTCALL(call_rcu_bh(struct rcu_head *head,
 				void (*func)(struct rcu_head *head)));
-extern __deprecated_for_modules void synchronize_kernel(void);
 extern void synchronize_rcu(void);
 void synchronize_idle(void);
 extern void rcu_barrier(void);
kernel/rcupdate.c renamed from kernel/rcupdate.c.old +0 -9
@@ -593,14 +593,6 @@
 	wait_for_completion(&rcu.completion);
 }
 
-/*
- * Deprecated, use synchronize_rcu() or synchronize_sched() instead.
- */
-void synchronize_kernel(void)
-{
-	synchronize_rcu();
-}
-
 module_param(blimit, int, 0);
 module_param(qhimark, int, 0);
 module_param(qlowmark, int, 0);
@@ -611,4 +603,3 @@
 EXPORT_SYMBOL_GPL_FUTURE(call_rcu);	/* WARNING: GPL-only in April 2006. */
 EXPORT_SYMBOL_GPL_FUTURE(call_rcu_bh);	/* WARNING: GPL-only in April 2006. */
 EXPORT_SYMBOL_GPL(synchronize_rcu);
-EXPORT_SYMBOL_GPL_FUTURE(synchronize_kernel); /* WARNING: GPL-only in April 2006. */
#3 lore raw
Quoted 10 lines · Andreas Mohr

Hi,

Quoted 3 lines · Adrian Bunk

synchronize_kernel() is both deprecated and completely unused.

Let's kill this bloat.

Probably a good idea, but then it's not too useful to have
http://lse.sourceforge.net/locking/rcu/HOWTO/descrip.html
still prominently mention it...

My May 1st patches will update the documentation files as well, also the -rt tree. Please let me take care of this.

Thanx, Paul