Skip to contentSkip to conversation

cell: correctly detect systemsim host

PATCH In review Christian Krafft 3 participants 3 messages Apr 13, 2006 – Apr 14, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cell: correctly detect systemsim host

Systemsim uses a different compatible property in the device tree.

---

arch/powerpc/platforms/cell/setup.c +6 -3
Index: linux/arch/powerpc/platforms/cell/setup.c
===================================================================
@@ -222,10 +222,13 @@ static int __init cell_probe(void)
 	 * more appropriate detection logic
 	 */
 	unsigned long root = of_get_flat_dt_root();
-	if (!of_flat_dt_is_compatible(root, "IBM,CPBW-1.0"))
-		return 0;
+	if (of_flat_dt_is_compatible(root, "IBM,CPBW-1.0"))
+		return 1;
 
-	return 1;
+	if (of_flat_dt_is_compatible(root, "IBM,CPBW-SystemSim"))
+		return 1;
+
+	return 0;
 }
 
 /*
#1 lore raw
Quoted 3 lines · Christian Krafft

Systemsim uses a different compatible property in the device tree.

Thanks.

I'm wondering if we should have that upstream, since some more patches are currently required to run on systemsim anyway. For now, I'll keep it in my tree.

	Arnd <><
Acked-by
#2 lore raw
Quoted 9 lines
Quoted 3 lines

Systemsim uses a different compatible property in the device tree.

Thanks.

I'm wondering if we should have that upstream, since some more patches are currently required to run on systemsim anyway. For now, I'll keep it in my tree.

It is clean enough to go upstream and doesn't depend on anything else, so I say put it upstream. That's just one less patch to carry outside of mainline. No reason to punish perfectly good patches just because the rest of the systemsim stuff isn't ready yet.

-Joel