Fix crash on big-endian systems during scan
Subsystems (3)
PATCH 1/1 Fix crash on big-endian systems during scan
From: Pavel Roskin <[email protected]>
The original code was doing arithmetics on a little-endian value. Reported by Stelios Koroneos <[email protected]>
---
drivers/net/wireless/hostap/hostap_ioctl.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/net/wireless/hostap/hostap_ioctl.c +2 -2
@@ -1860,7 +1860,7 @@ static char * __prism2_translate_scan(lomemset (&iwe,0 ,sizeof (iwe)); iwe.cmd =SIOCGIWFREQ ;if (scan) { - chan = scan->chid; + chan =le16_to_cpu (scan->chid); }else if (bss) { chan = bss->chan; }else {
@@ -1868,7 +1868,7 @@ static char * __prism2_translate_scan(lo }if (chan >0 ) { - iwe.u.freq.m = freq_list[le16_to_cpu (chan -1 )] *100000 ; + iwe.u.freq.m = freq_list[chan -1 ] *100000 ; iwe.u.freq.e =1 ; current_ev =iwe_stream_add_event (current_ev, end_buf, &iwe,IW_EV_FREQ_LEN );
Quoted 1 line · Pavel Roskin
The original code was doing arithmetics on a little-endian value.
John, please apply this to wireless-2.6 tree. This code is triggered at least for the case where WPA is not used. I had noticed it before, but I think I've only tested WPA/WPA2 on big endian systems..
Signature · 1 line
Jouni Malinen PGP id EFC895FA
Quoted 7 lines · Jouni Malinen
Quoted 1 line · Pavel Roskin
The original code was doing arithmetics on a little-endian value.
John, please apply this to wireless-2.6 tree. This code is triggered at least for the case where WPA is not used. I had noticed it before, but I think I've only tested WPA/WPA2 on big endian systems..
Can someone repost this patch? I seem to have missed it.
Thanks,
John
Signature · 2 lines
John W. Linville [email protected]
Quoted 10 lines · John W. Linville
Quoted 7 lines · Jouni Malinen
Quoted 1 line · Pavel Roskin
The original code was doing arithmetics on a little-endian value.
John, please apply this to wireless-2.6 tree. This code is triggered at least for the case where WPA is not used. I had noticed it before, but I think I've only tested WPA/WPA2 on big endian systems..
Can someone repost this patch? I seem to have missed it.
Pavel posted to netdev originally on Friday April 14th with the patch included in the email, with the title "[PATCH] Fix crash on big-endian systems during scan"...
http://www.spinics.net/lists/netdev/msg03023.html
Sure you don't have it somewhere? If not, I'm sure somebody can resend...
Dan
Quoted 8 lines · Dan Williams
Pavel posted to netdev originally on Friday April 14th with the patch included in the email, with the title "[PATCH] Fix crash on big-endian systems during scan"...
http://www.spinics.net/lists/netdev/msg03023.html
Sure you don't have it somewhere? If not, I'm sure somebody can resend...
I must have fat-fingered a delete...sorry!
A repost would be most welcome...
John
Signature · 2 lines
John W. Linville [email protected]
Quoted 6 lines · John W. Linville
Quoted 4 lines · Dan Williams
Pavel posted to netdev originally on Friday April 14th with the patch included in the email, with the title "[PATCH] Fix crash on big-endian systems during scan"...
Quoted 8 lines
Quoted 4 lines
http://www.spinics.net/lists/netdev/msg03023.html
Sure you don't have it somewhere? If not, I'm sure somebody can resend...
I must have fat-fingered a delete...sorry!
A repost would be most welcome...
I think Pavel just resent the patch with a "(repost)" at the end of the subject line.
Dan
Quoted 12 lines · Dan Williams
Quoted 11 lines · John W. Linville
Quoted 8 lines · Dan Williams
Pavel posted to netdev originally on Friday April 14th with the patch included in the email, with the title "[PATCH] Fix crash on big-endian systems during scan"...
http://www.spinics.net/lists/netdev/msg03023.html
Sure you don't have it somewhere? If not, I'm sure somebody can resend...
Quoted 6 lines
Quoted 3 lines
I must have fat-fingered a delete...sorry!
A repost would be most welcome...
I think Pavel just resent the patch with a "(repost)" at the end of the subject line.
Hmmm...Randy Dunlap said offline that he had reposted, but I haven't seen one from him either...is it a big patch?
John
Signature · 2 lines
John W. Linville [email protected]
Quoted 15 lines · John W. Linville
Quoted 14 lines · Dan Williams
Quoted 13 lines · John W. Linville
Quoted 8 lines · Dan Williams
Pavel posted to netdev originally on Friday April 14th with the patch included in the email, with the title "[PATCH] Fix crash on big-endian systems during scan"...
http://www.spinics.net/lists/netdev/msg03023.html
Sure you don't have it somewhere? If not, I'm sure somebody can resend...
I must have fat-fingered a delete...sorry!
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
A repost would be most welcome...
I think Pavel just resent the patch with a "(repost)" at the end of the subject line.
Hmmm...Randy Dunlap said offline that he had reposted, but I haven't seen one from him either...is it a big patch?
Two liner...
From: Pavel Roskin <[email protected]>
The original code was doing arithmetics on a little-endian value. Reported by Stelios Koroneos <[email protected]>
---
drivers/net/wireless/hostap/hostap_ioctl.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/net/wireless/hostap/hostap_ioctl.c +2 -2
@@ -1860,7 +1860,7 @@ static char * __prism2_translate_scan(lomemset (&iwe,0 ,sizeof (iwe)); iwe.cmd =SIOCGIWFREQ ;if (scan) { - chan = scan->chid; + chan =le16_to_cpu (scan->chid); }else if (bss) { chan = bss->chan; }else {
@@ -1868,7 +1868,7 @@ static char * __prism2_translate_scan(lo }if (chan >0 ) { - iwe.u.freq.m = freq_list[le16_to_cpu (chan -1 )] *100000 ; + iwe.u.freq.m = freq_list[chan -1 ] *100000 ; iwe.u.freq.e =1 ; current_ev =iwe_stream_add_event (current_ev, end_buf, &iwe,IW_EV_FREQ_LEN );
Quoted 26 lines · Dan Williams
Quoted 15 lines · John W. Linville
Quoted 14 lines · Dan Williams
Quoted 13 lines · John W. Linville
Quoted 8 lines · Dan Williams
Pavel posted to netdev originally on Friday April 14th with the patch included in the email, with the title "[PATCH] Fix crash on big-endian systems during scan"...
http://www.spinics.net/lists/netdev/msg03023.html
Sure you don't have it somewhere? If not, I'm sure somebody can resend...
I must have fat-fingered a delete...sorry!
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
A repost would be most welcome...
I think Pavel just resent the patch with a "(repost)" at the end of the subject line.
Hmmm...Randy Dunlap said offline that he had reposted, but I haven't seen one from him either...is it a big patch?
Two liner...
Quoted 7 lines
From: Pavel Roskin <[email protected]>
The original code was doing arithmetics on a little-endian value. Reported by Stelios Koroneos <[email protected]>
Signed-off-by Pavel Roskin <[email protected]>---
Got this one...thanks!
Signature · 2 lines
John W. Linville [email protected]