Skip to contentSkip to conversation

Default CONFIG_DEBUG_MUTEXES to n

PATCH In review Martin J. Bligh 2 participants 2 messages Apr 15, 2006 Library code

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Default CONFIG_DEBUG_MUTEXES to n

CONFIG_DEBUG_MUTEXES has a significant performant impact (reduced perf of reaim by 50% on ia32 NUMA boxes). It should not be on by default.

lib/Kconfig.debug +2 -1
diff -aurpN -X /home/mbligh/.diff.exclude linux-2.6.17-rc1/lib/Kconfig.debug 2.6.17-rc1_no_mutex_dbg/lib/Kconfig.debug
@@ -101,7 +101,7 @@ config DEBUG_PREEMPT
 
 config DEBUG_MUTEXES
 	bool "Mutex debugging, deadlock detection"
-	default y
+	default n
 	depends on DEBUG_KERNEL
 	help
 	 This allows mutex semantics violations and mutex related deadlocks
@@ -109,6 +109,7 @@ config DEBUG_MUTEXES
 
 config DEBUG_SPINLOCK
 	bool "Spinlock debugging"
+	default n
 	depends on DEBUG_KERNEL
 	help
 	  Say Y here and build SMP to catch missing spinlock initialization
#1 lore raw
Quoted 11 lines · Martin J. Bligh

CONFIG_DEBUG_MUTEXES has a significant performant impact (reduced perf of reaim by 50% on ia32 NUMA boxes). It should not be on by default.

diff -aurpN -X /home/mbligh/.diff.exclude linux-2.6.17-rc1/lib/Kconfig.debug 2.6.17-rc1_no_mutex_dbg/lib/Kconfig.debug

lib/Kconfig.debug config DEBUG_PREEMPT

Quoted 10 lines
lib/Kconfig.debug +2 -1
@@ -101,7 +101,7 @@ config DEBUG_PREEMPT
 
 config DEBUG_MUTEXES
 	bool "Mutex debugging, deadlock detection"
-	default y
+	default n
...
 config DEBUG_SPINLOCK
 	bool "Spinlock debugging"
+	default n
...

"default n" has no effect and can be removed.

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed