Skip to contentSkip to conversation

unaligned access in sk_run_filter()

PATCH In review Kirill Korotaev 2 participants 2 messages Apr 17, 2006 – Apr 18, 2006

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 unaligned access in sk_run_filter()

[PATCH] unaligned access in sk_run_filter()

This patch fixes unaligned access warnings noticed on IA64 in sk_run_filter(). 'ptr' can be unaligned.

net/core/filter.c renamed from net/core/filter.c.ve125 +3 -2
@@ -34,6 +34,7 @@
 #include <linux/timer.h>
 #include <asm/system.h>
 #include <asm/uaccess.h>
+#include <asm/unaligned.h>
 #include <linux/filter.h>
 
 /* No hurry in this branch */
@@ -177,7 +178,7 @@ unsigned int sk_run_filter(struct sk_buf
 load_w:
 			ptr = load_pointer(skb, k, 4, &tmp);
 			if (ptr != NULL) {
-				A = ntohl(*(u32 *)ptr);
+				A = ntohl(get_unaligned((u32 *)ptr));
 				continue;
 			}
 			break;
@@ -186,7 +187,7 @@ load_w:
 load_h:
 			ptr = load_pointer(skb, k, 2, &tmp);
 			if (ptr != NULL) {
-				A = ntohs(*(u16 *)ptr);
+				A = ntohs(get_unaligned((u16 *)ptr));
 				continue;
 			}
 			break;