i386: Move CONFIG_DOUBLEFAULT into arch/i386 where it belongs.
PATCH 6/6 i386: Move CONFIG_DOUBLEFAULT into arch/i386 where it belongs.
--- arch/i386/Kconfig.debug | 9 +++++++++ init/Kconfig | 9 --------- 2 files changed, 9 insertions(+), 9 deletions(-)
arch/i386/Kconfig.debug +9 -0
@@ -81,4 +81,13 @@ config X86_MPPARSE depends on X86_LOCAL_APIC && !X86_VISWS default y +config DOUBLEFAULT + default y + bool "Enable doublefault exception handler" if EMBEDDED + help + This option allows trapping of rare doublefault exceptions that + would otherwise cause a system to silently reboot. Disabling this + option saves about 4k and might cause you much additional grey + hair. + endmenu
init/Kconfig +0 -9
@@ -374,15 +374,6 @@ config SLAB SLOB is more space efficient but does not scale well and is more susceptible to fragmentation. -config DOUBLEFAULT - default y - bool "Enable doublefault exception handler" if EMBEDDED && X86_32 - help - This option allows trapping of rare doublefault exceptions that - would otherwise cause a system to silently reboot. Disabling this - option saves about 4k and might cause you much additional grey - hair. - endmenu # General setup config TINY_SHMEM
Adrian Bunk
NAKQuoted 3 lines · Andi Kleen
Signed-off-by Andi Kleen <[email protected]>...
NAK.
When submitting a patch that is the revert of a patch that went into Linus' tree just 8 days ago [1], I'd expect at least:
- a Cc to the people involved with the patch you are reverting
- a note that you are reverting a recent patch in your patch description
- an explanation why you disagree with the patch you are reverting
If you disagree with a patch, please speak up when it's submitted or discuss it after you've seen it in the tree. But don't play such silly revert-and-hope-they-don't-notice-I've-reverted-it games.
cu
Adrian
[1] commit e39632faa0efbddc3aed4f8658f2fa0a8afa2717
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon SeedQuoted 5 lines · Adrian Bunk
Quoted 3 lines · Andi Kleen
Signed-off-by Andi Kleen <[email protected]>...
Quoted 8 lines
NAK.
When submitting a patch that is the revert of a patch that went into Linus' tree just 8 days ago [1], I'd expect at least:
- a Cc to the people involved with the patch you are reverting
- a note that you are reverting a recent patch in your patch description
- an explanation why you disagree with the patch you are reverting
The subject was very clear. i386 options belong into arch/i386.
Quoted 3 lines
If you disagree with a patch, please speak up when it's submitted or discuss it after you've seen it in the tree. But don't play such silly revert-and-hope-they-don't-notice-I've-reverted-it games.
I moved it because I noticed that my x86-64 configuration files had this strange new symbol. I also did a grep and no other architecture other than i386 uses it.
i386 specific hacks belong into arch/i386
-Andi (who actually thinks the whole thing was always a bad idea - saving a few K but giving up such debugging is a poor trade off)
Quoted 14 lines · On Tue, 18 Apr 2006 22:12:13 +0200 Andi Kleen wrote:
Quoted 5 lines · Adrian Bunk
Quoted 3 lines · Andi Kleen
Signed-off-by Andi Kleen <[email protected]>...
Quoted 7 lines
NAK.
submitting a patch that is the revert of a patch that went
into Linus' tree just 8 days ago [1], I'd expect at least:
- a Cc to the people involved with the patch you are reverting
- a note that you are reverting a recent patch in your patch description
- an explanation why you disagree with the patch you are reverting
Quoted 1 line
The subject was very clear. i386 options belong into
arch/i386.
Yes, the timing could have been better. Whatever.
I agree with Andi that it should be moved back to the ix86 Processor menu, but not where he moved it to. My patch is below.
Quoted 2 lines
-Andi (who actually thinks the whole thing was always a bad idea - saving a few K but giving up such debugging is a poor trade off)
It does default to Y and can only be changed if EMBEDDED is enabled. I don't think that it really should be in the Kernel hacking menu.
---
From: Randy Dunlap <[email protected]>
Put DOUBLEFAULT option back in the i386 Processor menu, but not at the very top of it like it was originally, where it was out of place in the menu structure.
--- arch/i386/Kconfig | 9 +++++++++ init/Kconfig | 9 --------- 2 files changed, 9 insertions(+), 9 deletions(-)
arch/i386/Kconfig +9 -0
@@ -282,6 +282,15 @@ config X86_VISWS_APIC depends on X86_VISWS default y +config DOUBLEFAULT + default y + bool "Enable doublefault exception handler" if EMBEDDED + help + This option allows trapping of rare doublefault exceptions that + would otherwise cause a system to silently reboot. Disabling this + option saves about 4k and might cause you much additional grey + hair. + config X86_MCE bool "Machine Check Exception" depends on !X86_VOYAGER
init/Kconfig +0 -9
@@ -374,15 +374,6 @@ config SLAB SLOB is more space efficient but does not scale well and is more susceptible to fragmentation. -config DOUBLEFAULT - default y - bool "Enable doublefault exception handler" if EMBEDDED && X86_32 - help - This option allows trapping of rare doublefault exceptions that - would otherwise cause a system to silently reboot. Disabling this - option saves about 4k and might cause you much additional grey - hair. - endmenu # General setup config TINY_SHMEM
---
Quoted 16 lines · Randy.Dunlap
Quoted 14 lines · On Tue, 18 Apr 2006 22:12:13 +0200 Andi Kleen wrote:
Quoted 12 lines · Adrian Bunk
Quoted 3 lines · Andi Kleen
Signed-off-by Andi Kleen <[email protected]>...
NAK.
submitting a patch that is the revert of a patch that went
into Linus' tree just 8 days ago [1], I'd expect at least:
- a Cc to the people involved with the patch you are reverting
- a note that you are reverting a recent patch in your patch description
- an explanation why you disagree with the patch you are reverting
Quoted 7 lines
Quoted 1 line
The subject was very clear. i386 options belong into
arch/i386.Yes, the timing could have been better. Whatever.
I agree with Andi that it should be moved back to the ix86 Processor menu, but not where he moved it to. My patch is below.
...
I'd still disagree with Andi regarding this point (but it's not a very important issue).
My main problem with his patch is still the way he did it - sending a patch reverting a recently included patch with neither discussion before the patch nor mentioning in the patch that it's a revert nor a Cc to the people involved with the patch.
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon SeedQuoted 4 lines · Adrian Bunk
My main problem with his patch is still the way he did it - sending a patch reverting a recently included patch with neither discussion before the patch nor mentioning in the patch that it's a revert nor a Cc to the people involved with the patch.
I just noticed a problem (bogus symbols in my x86-64 config) and fixed it. I normally don't look at which patch it introduced for such trivial changes.
-Andi
Quoted 9 lines · Andi Kleen
Quoted 4 lines · Adrian Bunk
My main problem with his patch is still the way he did it - sending a patch reverting a recently included patch with neither discussion before the patch nor mentioning in the patch that it's a revert nor a Cc to the people involved with the patch.
I just noticed a problem (bogus symbols in my x86-64 config) and fixed it. I normally don't look at which patch it introduced for such trivial changes.
First of all, the "problem" of an unset config variable in the .config is at most a cosmetical issue.
And even if it had been a real problem, discussing such an issue and convincing people why you consider it to be bad is always better, since whoever gets conviced in the situation will have learned for similar future cases.
There are ways how things should work and we should follow them.
As an example, there is one trivial x86_64 specific patch removing the small bloat caused by an unused export I made in -mm Andrew has forwarded at least twice to you.
Until now, I'd have considered it an unfriendly act to forward such a patch to Linus through my trivial tree bypassing you as the maintainer, but looking at your statement it seems to be OK for you if I send such trivial patches directly to Linus without bothering to go through you as the maintainer.
Quoted 1 line
-Andi
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed