Fix filename scaling for binary files

PATCH New Jonas Fonseca 1 participant 1 message Jun 15, 2016

lore

Share & tools

lore

Jonas Fonseca

author

2016-06-15 22:42 UTC #0 lore raw

PATCH 1/1 Fix filename scaling for binary files

Set maximum filename length for binary files so that scaling won't be triggered and result in invalid string access.

Signed-off-by Jonas Fonseca <[email protected]>

---

 diff.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diff.c +4 -3

index b54bbfa..ddcfb84 100644
@@ -250,13 +250,14 @@ static void show_stats(struct diffstat_t
 	for (i = 0; i < data->nr; i++) {
 		struct diffstat_file *file = data->files[i];
 
+		len = strlen(file->name);
+		if (max_len < len)
+			max_len = len;
+
 		if (file->is_binary || file->is_unmerged)
 			continue;
 		if (max_change < file->added + file->deleted)
 			max_change = file->added + file->deleted;
-		len = strlen(file->name);
-		if (max_len < len)
-			max_len = len;
 	}
 
 	for (i = 0; i < data->nr; i++) {

Signature · 1 line

Jonas Fonseca