Skip to contentSkip to conversation

fix section mismatch in pm2fb.o

PATCH In review Adrian Bunk 2 participants 2 messages Apr 18, 2006 – Apr 19, 2006 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix section mismatch in pm2fb.o

From: Darren Jenkins <[email protected]>

There are a couple of Section mismatch problems in drivers/video/pm2fb.o

WARNING: drivers/video/pm2fb.o - Section mismatch: reference to .init.data: from .text after 'pm2fb_set_par' (at offset 0xd5d)
WARNING: drivers/video/pm2fb.o - Section mismatch: reference to .init.data: from .text after 'pm2fb_set_par' (at offset 0xd82)

They are caused because pm2fb_set_par() uses lowhsync and lowvsync which are marked __devinitdata.

This patch simply removes the __devinitdata annotations.

---

This patch was already sent on:
- 9 Apr 2006

drivers/video/pm2fb.c renamed from drivers/video/pm2fb.c.orig +2 -2
@@ -73,8 +73,8 @@ static char *mode __devinitdata = NULL;
  * these flags allow the user to specify that requests for +ve sync
  * should be silently turned in -ve sync.
  */
-static int lowhsync __devinitdata = 0;
-static int lowvsync __devinitdata = 0;
+static int lowhsync = 0;
+static int lowvsync = 0;
 
 /*
  * The hardware state of the graphics card that isn't part of the
#1 lore raw
Quoted 25 lines · On Wed, 19 Apr 2006 01:50:38 +0200 Adrian Bunk wrote:

From: Darren Jenkins <[email protected]>

There are a couple of Section mismatch problems in drivers/video/pm2fb.o

WARNING: drivers/video/pm2fb.o - Section mismatch: reference to .init.data: from .text after 'pm2fb_set_par' (at offset 0xd5d)
WARNING: drivers/video/pm2fb.o - Section mismatch: reference to .init.data: from .text after 'pm2fb_set_par' (at offset 0xd82)

They are caused because pm2fb_set_par() uses lowhsync and lowvsync which are marked __devinitdata.

This patch simply removes the __devinitdata annotations.

---

This patch was already sent on:
- 9 Apr 2006

drivers/video/pm2fb.c static char *mode __devinitdata = NULL; · line 80

Quoted 10 lines
drivers/video/pm2fb.c renamed from drivers/video/pm2fb.c.orig +2 -2
@@ -73,8 +73,8 @@ static char *mode __devinitdata = NULL;
  * these flags allow the user to specify that requests for +ve sync
  * should be silently turned in -ve sync.
  */
-static int lowhsync __devinitdata = 0;
-static int lowvsync __devinitdata = 0;
+static int lowhsync = 0;
+static int lowvsync = 0;
 
 /*
  * The hardware state of the graphics card that isn't part of the

I'll ack that since I've already posted it to linux-fbdev-devel and it's been acked there.

---
~Randy