Skip to contentSkip to conversation

tpm: fix missing string

PATCH In review Kylene Jo Hall 2 participants 3 messages Apr 19, 2006 – Apr 20, 2006 TPM device driver

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tpm: fix missing string

A string corresponding to the tcpa_pc_event_id POST_CONTENTS was missing causing an overflow bug when access was attempted in the get_event_name function.

This bug was found by Coverity.

---
 drivers/char/tpm/tpm_bios.c |    1 +
 1 files changed, 1 insertion(+)
drivers/char/tpm/tpm_bios.c +1 -0
@@ -134,6 +134,7 @@ static const char* tcpa_pc_event_id_stri
 	"S-CRTM Version",
 	"S-CRTM Contents",
 	"S-CRTM POST Contents",
+	"POST Contents",
 };
 
 /* returns pointer to start of pos. entry of tcg log */
#1 lore raw
Quoted 4 lines · Kylene Jo Hall

A string corresponding to the tcpa_pc_event_id POST_CONTENTS was missing
causing an overflow bug when access was attempted in the get_event_name function.

These last two bugs are applicable to 2.6.17.

I'm kind of thinking of pushing all the TPM patches into 2.6.17 actually. Although there's quite a lot of feature work in there, we also have bugfixes, although relatively minor ones.

What's your confidence level in those patches?

Would you have time to do a decent round of regression testing against the resulting TPM code prior to 2.6.17? Say, inside the next couple of weeks?

#2 lore raw
Quoted 7 lines · Andrew Morton
Quoted 4 lines · Kylene Jo Hall

A string corresponding to the tcpa_pc_event_id POST_CONTENTS was missing
causing an overflow bug when access was attempted in the get_event_name function.

These last two bugs are applicable to 2.6.17.

Correct.

Quoted 9 lines

I'm kind of thinking of pushing all the TPM patches into 2.6.17 actually. Although there's quite a lot of feature work in there, we also have bugfixes, although relatively minor ones.

What's your confidence level in those patches?

Would you have time to do a decent round of regression testing against the resulting TPM code prior to 2.6.17? Say, inside the next couple of weeks?

I'm pretty confident. Yesterday's bug fixes were the last things I know of that needed attention. I'd be happy to run regression testing in the next couple of weeks.

Thanks,
Kylie