kernel/audit.c: remove unused exports
RFC PATCH 1/1 kernel/audit.c: remove unused exports
This patch removes the following unused EXPORT_SYMBOL's:
- audit_log_start
- audit_log_end
- audit_log_format
- audit_log
kernel/audit.c renamed from kernel/audit.c.old +0 -4
@@ -1092,7 +1092,3 @@ } } -EXPORT_SYMBOL (audit_log_start); -EXPORT_SYMBOL (audit_log_end); -EXPORT_SYMBOL (audit_log_format); -EXPORT_SYMBOL (audit_log);
Quoted 11 lines · Adrian Bunk
This patch removes the following unused EXPORT_SYMBOL's:
-audit_log_start
-audit_log_end
-audit_log_format
-audit_logSigned-off-by Adrian Bunk <[email protected]>
kernel/audit.c line 1098
Quoted 7 lines
kernel/audit.c renamed from kernel/audit.c.old +0
-4@@ -1092,7 +1092,3 @@ } } -EXPORT_SYMBOL (audit_log_start); -EXPORT_SYMBOL (audit_log_end); -EXPORT_SYMBOL (audit_log_format); -EXPORT_SYMBOL (audit_log);
It would seem useful to allow out of tree modules (even if they never have a goal of submitting to become intree) to log audit data. No? A reason to prevent it seems utterly lost on me.
Tony
Quoted 15 lines · Tony Jones
Quoted 14 lines · Adrian Bunk
This patch removes the following unused EXPORT_SYMBOL's:
-audit_log_start
-audit_log_end
-audit_log_format
-audit_logSigned-off-by Adrian Bunk <[email protected]>kernel/audit.c renamed from kernel/audit.c.old +0
-0@@ -1092,7 +1092,3 @@ } }
Quoted 8 lines
kernel/audit.c line 1098
Quoted 4 lines
kernel/audit.c renamed from kernel/audit.c.old +0
-4-EXPORT_SYMBOL (audit_log_start); -EXPORT_SYMBOL (audit_log_end); -EXPORT_SYMBOL (audit_log_format); -EXPORT_SYMBOL (audit_log);It would seem useful to allow out of tree modules (even if they never have a goal of submitting to become intree) to log audit data. No? A reason to prevent it seems utterly lost on me.
Out of tree modules without the goal of being submitted are not a good idea.
AppArmor/LSM is a good example what can happen if people don't submit their external modules for inclusion in the kernel.
Quoted 1 line
Tony
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon SeedQuoted 2 lines · Adrian Bunk
Out of tree modules without the goal of being submitted are not a good idea.
And what are people to do while developing modules that are not ready for inclusion? This is a generic API for use by anyone. If virus scanning or IDS companies need to use the API, shouldn't they be allowed to?
-Steve
Quoted 3 lines · Steve Grubb
And what are people to do while developing modules that are not ready for inclusion? This is a generic API for use by anyone. If virus scanning or IDS companies need to use the API, shouldn't they be allowed to?
Yes, but only if their code is GPL'd.
Signature · 1 line
dwmw2
Quoted 11 lines · Adrian Bunk
Quoted 8 lines
kernel/audit.c line 1098
Quoted 4 lines
kernel/audit.c renamed from kernel/audit.c.old +0
-4-EXPORT_SYMBOL (audit_log_start); -EXPORT_SYMBOL (audit_log_end); -EXPORT_SYMBOL (audit_log_format); -EXPORT_SYMBOL (audit_log);It would seem useful to allow out of tree modules (even if they never have a goal of submitting to become intree) to log audit data. No? A reason to prevent it seems utterly lost on me.
Out of tree modules without the goal of being submitted are not a good idea.
What a stupid comment (in general and expecially given the nature of the audit subsystem ). Sorry.
Also, there are probably at present no intree users of audit other than compiled built-in. I'm guessing by your patch you believe built-in to be the only valid configuration mode for said users :-)
EXPORT_SYMBOL_GPL, sure.
Quoted 2 lines
AppArmor/LSM is a good example what can happen if people don't submit their external modules for inclusion in the kernel.
LOL. Thanks for the daily laugh.
Tony
Quoted 16 lines · Tony Jones
Quoted 11 lines · Adrian Bunk
Quoted 8 lines
kernel/audit.c line 1098
Quoted 4 lines
kernel/audit.c renamed from kernel/audit.c.old +0
-4-EXPORT_SYMBOL (audit_log_start); -EXPORT_SYMBOL (audit_log_end); -EXPORT_SYMBOL (audit_log_format); -EXPORT_SYMBOL (audit_log);It would seem useful to allow out of tree modules (even if they never have a goal of submitting to become intree) to log audit data. No? A reason to prevent it seems utterly lost on me.
Out of tree modules without the goal of being submitted are not a good idea.
What a stupid comment (in general and expecially given the nature of the audit subsystem ). Sorry.
Quoted 6 lines
Also, there are probably at present no intree users of audit other than compiled built-in. I'm guessing by your patch you believe built-in to be the only valid configuration mode for said users :-)
EXPORT_SYMBOL_GPL, sure.
...
I don't have a fixed opinion about whether future in-kernel users of the audit subsystem could be modules.
Currently there are none, and if modular users get added at some point in the future re-exporting them will be trivial.
Until then, removing the exports simply makes the kernel image a bit smaller.
Quoted 1 line
Tony
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon SeedQuoted 5 lines · Adrian Bunk
This patch removes the following unused EXPORT_SYMBOL's:
-audit_log_start
-audit_log_end
-audit_log_format
-audit_log
These are to allow 3rd party security modules log to the audit system.
-Steve
Quoted 1 line · Steve Grubb
These are to allow 3rd party security modules log to the audit system.
They should be EXPORT_SYMBOL_GPL though, at least.
Signature · 1 line
dwmw2