Skip to contentSkip to conversation

remove the Root Plug Support sample module

PATCH In review Adrian Bunk 4 participants 6 messages Apr 21, 2006 – Apr 22, 2006 Security (LSM)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 remove the Root Plug Support sample module

No matter whether LSM will stay or not, there's no reason to include a sample module in the build (e.g. Debian kernels are currently shipping this module).

---

 security/Kconfig     |   13 ---
 security/Makefile    |    1 
 security/root_plug.c |  142 -------------------------------------------
 3 files changed, 156 deletions(-)
security/Kconfig renamed from security/Kconfig.old +0 -13
@@ -74,19 +74,6 @@
 	  This enables the "default" Linux capabilities functionality.
 	  If you are unsure how to answer this question, answer Y.
 
-config SECURITY_ROOTPLUG
-	tristate "Root Plug Support"
-	depends on USB && SECURITY
-	help
-	  This is a sample LSM module that should only be used as such.
-	  It prevents any programs running with egid == 0 if a specific
-	  USB device is not present in the system.
-
-	  See <http://www.linuxjournal.com/article.php?sid=6279> for
-	  more information about this module.
-	  
-	  If you are unsure how to answer this question, answer N.
-
 config SECURITY_SECLVL
 	tristate "BSD Secure Levels"
 	depends on SECURITY
security/Makefile renamed from security/Makefile.old +0 -1
@@ -15,5 +15,4 @@
 # Must precede capability.o in order to stack properly.
 obj-$(CONFIG_SECURITY_SELINUX)		+= selinux/built-in.o
 obj-$(CONFIG_SECURITY_CAPABILITIES)	+= commoncap.o capability.o
-obj-$(CONFIG_SECURITY_ROOTPLUG)		+= commoncap.o root_plug.o
 obj-$(CONFIG_SECURITY_SECLVL)		+= seclvl.o
security/root_plug.c deleted +0 -142

142 lines not on this page · raw message

#1 lore raw
Quoted 3 lines · * Adrian Bunk ([email protected]) wrote:

No matter whether LSM will stay or not, there's no reason to include a sample module in the build (e.g. Debian kernels are currently shipping this module).

I've no issue with this. Greg, unless you object, I'll pick this one up.

thanks,
-chris

#2 lore raw
In reply to Adrian Bunk
Quoted 5 lines · Adrian Bunk

No matter whether LSM will stay or not, there's no reason to include a sample module in the build (e.g. Debian kernels are currently shipping this module).

As much as I'd like to agree with this (SuSE also ships this module for some odd reason), I do have reports of people using it for their machines at times.

So, I'd like to keep this in the tree, for as long as the LSM interface sticks around, if possible. It's not hurting anything, and it does work for users, and is a good example starting point for people wanting to use the LSM interface.

Unless there are any known security problems with it? If so, please let me know.

thanks,

greg k-h

#3 lore raw
Quoted 8 lines · Greg KH

...
So, I'd like to keep this in the tree, for as long as the LSM interface sticks around, if possible. It's not hurting anything, and it does work for users, and is a good example starting point for people wanting to use the LSM interface.

Unless there are any known security problems with it? If so, please let me know.

Using USB Vendor ID/USB Product ID for identifying an USB device doesn't seem to bring real security since:
- every other device of the same type works as well
- using an arbitrary USB device with a manipulated
USB Vendor ID/USB Product ID seems quite possible

It might work as an example, but if people think it would bring them real security that's a dangerous misunderstanding.

Quoted 3 lines

thanks,

greg k-h

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#4 lore raw
Quoted 2 lines · Adrian Bunk

It might work as an example, but if people think it would bring them real security that's a dangerous misunderstanding.

Examples are good, no?

Sounds like you need to add a (well visible) comment then!!

Tony

#5 lore raw
In reply to Adrian Bunk
Quoted 10 lines · Adrian Bunk
Quoted 8 lines · Greg KH

...
So, I'd like to keep this in the tree, for as long as the LSM interface sticks around, if possible. It's not hurting anything, and it does work for users, and is a good example starting point for people wanting to use the LSM interface.

Unless there are any known security problems with it? If so, please let me know.

Quoted 8 lines

Using USB Vendor ID/USB Product ID for identifying an USB device doesn't seem to bring real security since:
- every other device of the same type works as well
- using an arbitrary USB device with a manipulated
USB Vendor ID/USB Product ID seems quite possible

It might work as an example, but if people think it would bring them real security that's a dangerous misunderstanding.

What it gives people is a level of security for users that do not have physical access to the machine. If you have access to it, yes, of course you can plug your own device in with the needed ids.

So, I'd still like to keep it around, unless LSM itself goes away.

thanks,

greg k-h