fs/inotify.c: possible cleanups
RFC PATCH 1/1 fs/inotify.c: possible cleanups
This patch contains the following possible cleanups:
- make the following needlessly global variables static:
- inotify_max_user_instances
- inotify_max_user_watches
- inotify_max_queued_events
- remove the following unused EXPORT_SYMBOL_GPL's:
- inotify_get_cookie
- inotify_unmount_inodes
- inotify_inode_is_dead
Signed-off-by Adrian Bunk <[email protected]>
---
fs/inotify.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)
fs/inotify.c renamed from fs/inotify.c.old +3 -6
@@ -45,9 +45,9 @@static struct vfsmount *inotify_mnt__read_mostly ;/* these are configurable via /proc/sys/fs/inotify/ */ -int inotify_max_user_instances__read_mostly ; -int inotify_max_user_watches__read_mostly ; -int inotify_max_queued_events__read_mostly ; +static int inotify_max_user_instances__read_mostly ; +static int inotify_max_user_watches__read_mostly ; +static int inotify_max_queued_events__read_mostly ;/* * Lock ordering:
@@ -627,7 +627,6 @@ {return atomic_inc_return (&inotify_cookie); } -EXPORT_SYMBOL_GPL (inotify_get_cookie);/** * inotify_unmount_inodes - an sb is unmounting. handle any watched inodes.
@@ -706,7 +705,6 @@spin_lock (&inode_lock); } } -EXPORT_SYMBOL_GPL (inotify_unmount_inodes);/** * inotify_inode_is_dead - an inode has been deleted, cleanup any watches
@@ -725,7 +723,6 @@ }mutex_unlock (&inode->inotify_mutex); } -EXPORT_SYMBOL_GPL (inotify_inode_is_dead);/* Device Interface */
Looks good.
Quoted 58 lines · Adrian Bunk
This patch contains the following possible cleanups:
- make the following needlessly global variables static:
-inotify_max_user_instances
-inotify_max_user_watches
-inotify_max_queued_events
- remove the following unused EXPORT_SYMBOL_GPL's:
-inotify_get_cookie
-inotify_unmount_inodes
-inotify_inode_is_deadSigned-off-by Adrian Bunk <[email protected]>---
fs/inotify.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)fs/inotify.c renamed from fs/inotify.c.old +3
-6@@ -45,9 +45,9 @@static struct vfsmount *inotify_mnt__read_mostly ;/* these are configurable via /proc/sys/fs/inotify/ */ -int inotify_max_user_instances__read_mostly ; -int inotify_max_user_watches__read_mostly ; -int inotify_max_queued_events__read_mostly ; +static int inotify_max_user_instances__read_mostly ; +static int inotify_max_user_watches__read_mostly ; +static int inotify_max_queued_events__read_mostly ;/* * Lock ordering: @@ -627,7 +627,6 @@ {return atomic_inc_return (&inotify_cookie); } -EXPORT_SYMBOL_GPL (inotify_get_cookie);/** * inotify_unmount_inodes - an sb is unmounting. handle any watched inodes. @@ -706,7 +705,6 @@spin_lock (&inode_lock); } } -EXPORT_SYMBOL_GPL (inotify_unmount_inodes);/** * inotify_inode_is_dead - an inode has been deleted, cleanup any watches @@ -725,7 +723,6 @@ }mutex_unlock (&inode->inotify_mutex); } -EXPORT_SYMBOL_GPL (inotify_inode_is_dead);/* Device Interface */
Signature · 1 line
John McCutchan <[email protected]>