Skip to contentSkip to conversation

s390: dasd ioctl never returns.

PATCH In review Martin Schwidefsky 1 participant 1 message Apr 24, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 6/13 s390: dasd ioctl never returns.

From: Horst Hummel <[email protected]>

[patch 6/13] s390: dasd ioctl never returns.

The dasd state machine is not designed to enable an unformatted device, since 'unformatted' is a final state. The BIODASDENABLE ioctl calls dasd_enable_device() which never returns if the device is in this special state. Return -EPERM in dasd_increase_state for unformatted devices to make dasd_enable_device terminate.
Note: To get such an unformatted device online it has to be re-analyzed. This means that the device needs to be disabled prior to re-enablement.

---

 drivers/s390/block/dasd.c |    5 +++++
 1 files changed, 5 insertions(+)
drivers/s390/block/dasd.c +5 -0
diff -urpN linux-2.6/drivers/s390/block/dasd.c linux-2.6-patched/drivers/s390/block/dasd.c
@@ -315,6 +315,11 @@ dasd_increase_state(struct dasd_device *
 		rc = dasd_state_basic_to_ready(device);
 
 	if (!rc &&
+	    device->state == DASD_STATE_UNFMT &&
+	    device->target > DASD_STATE_UNFMT)
+		rc = -EPERM;
+
+	if (!rc &&
 	    device->state == DASD_STATE_READY &&
 	    device->target >= DASD_STATE_ONLINE)
 		rc = dasd_state_ready_to_online(device);