Skip to contentSkip to conversation

rt2x00: dscape compatibilitiy

PATCH In review Ivo van Doorn 2 participants 3 messages Apr 27, 2006 – Apr 28, 2006

Subsystems (2)
lore
Share & tools
lore
#1 lore raw

Review rt2500pci_init_hw(struct rt2x00_pci *rt2 · line 2571

Quoted 8 lines · Ivo van Doorn

Latest dscape patches have broken rt2x00,
fix compile issues, and support the new features.

(quoted diff) +1 -0
@@ -2466,6 +2568,7 @@ rt2500pci_init_hw(struct rt2x00_pci *rt2
 	hw->no_tkip_wmm_hwaccel = 1;
 	hw->extra_hdr_room = 0;
 	hw->device_strips_mic = 0;
+	hw->monitor_during_oper = 1;

You should not set this to 1 if you support only one interface at a time. Please add support for concurrent running of one regular (i.e. STA, IBSS, AP, WDS) interface plus arbitrary number of monitor interfaces or set monitor_during_oper to 0.

(Yes, I know, I definitely must reserve some time to write a documentation about monitor mode support.)

Thanks,

Signature · 2 lines
Jiri Benc
SUSE Labs
#2 lore raw
Quoted 15 lines · Jiri Benc

Review rt2500pci_init_hw(struct rt2x00_pci *rt2 · line 2571

Quoted 8 lines · Ivo van Doorn

Latest dscape patches have broken rt2x00,
fix compile issues, and support the new features.

(quoted diff) +1 -0
@@ -2466,6 +2568,7 @@ rt2500pci_init_hw(struct rt2x00_pci *rt2
 	hw->no_tkip_wmm_hwaccel = 1;
 	hw->extra_hdr_room = 0;
 	hw->device_strips_mic = 0;
+	hw->monitor_during_oper = 1;

You should not set this to 1 if you support only one interface at a time. Please add support for concurrent running of one regular (i.e. STA, IBSS, AP, WDS) interface plus arbitrary number of monitor interfaces or set monitor_during_oper to 0.

Quoted 2 lines

(Yes, I know, I definitely must reserve some time to write a documentation about monitor mode support.)

My fault, this was a leftover from my initial patch for the dscape update. I actually had written some code to indeed allow multiple monitor mode interfaces. But I spotted some problems with it, and removed the code and planned to rewrite it later after I had send this code series. I'll create a quick patch to correctly set the monitor_during_oper variable, because the patch for correct monitor mode behaviour might take some time.