Skip to contentSkip to conversation

post 2.6.17-rc3 "Stop adding device ids to

KJ Henne 2 participants 2 messages Apr 28, 2006 – Apr 29, 2006 Kernel janitors

lore
Share & tools
lore

Henne

author
#0 lore raw

Hi there!

I've seen a change in the Documentation/pci.txt

http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h›860b8c4bde5949b272968597d1426d53080532

Does that really mean, that no Device-ID's should be added or should they be removed from include/linux/pci_ids.h? They could be replaced in the drivers, if they are used e.g. max 2 times, with the constant values or if they are used more than 2 times (for drivers who support more devices and check that) moved only to them.

I would write patches if this is in the sense of that.

Greets,
Henne

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors

#1 lore raw
Quoted 8 lines · Henne

Hi there!

I've seen a change in the Documentation/pci.txt

http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=9b860b8c4bde5949b272968597d1426d53080532

Does that really mean, that no Device-ID's should be added or should they be removed from include/linux/pci_ids.h?

No, just what it says, no new device ids should be added to that file, unless more than one driver uses it.

Quoted 6 lines

They could be replaced in the drivers, if they are used e.g. max 2 times, with the constant values or if they are used
more than 2 times (for drivers who support more devices and check that) moved only to them.

I would write patches if this is in the sense of that.

No, this isn't something that needs to be cleaned up, but rather something that shouldn't happen in the future.

hope this helps,

greg k-h

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors