Skip to contentSkip to conversation

powermac: U4 DART improvements

PATCH In review Olof Johansson 2 participants 3 messages Apr 30, 2006 – May 5, 2006 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powermac: U4 DART improvements

Hi,

Jimi Xenidis posted Xen drivers that do individual TLB shootdowns on U4 DART on Friday:

http://lists.xensource.com/archives/html/xen-ppc-devel/2006-04/msg00085.html

We haven't been able to do it before since we didn't know any register layouts past what Darwin used. So now we can implement individual teardown.

This boots happily on my quad at home, but I'd appreciate more testing by people who have U4-based machines. Also, if someone feels like doing some benchmarking to find the breakeven point between full invalidation and individual shootdowns, that'd be cool.

Patch below.

---

Implement single-entry TLB invalidations in the U4 DART.

At some point it makes more sense to invalidate the whole TLB instead of individual entries. I picked a breakpoint at 32 entries, but it might make sense to move it if benchmarking shows it to be too high or low.

arch/powerpc/sysdev/dart.h +5 -1
index c2d0576..1c8817c 100644
@@ -47,8 +47,12 @@
 /* U4 registers */
 #define DART_BASE_U4_BASE_MASK	0xffffff
 #define DART_BASE_U4_BASE_SHIFT	0
-#define DART_CNTL_U4_FLUSHTLB	0x20000000
 #define DART_CNTL_U4_ENABLE	0x80000000
+#define DART_CNTL_U4_IONE	0x40000000
+#define DART_CNTL_U4_FLUSHTLB	0x20000000
+#define DART_CNTL_U4_IDLE	0x10000000
+#define DART_CNTL_U4_PAR_EN	0x08000000
+#define DART_CNTL_U4_IONE_MASK	0x07ffffff
 #define DART_SIZE_U4_SIZE_MASK	0x1fff
 #define DART_SIZE_U4_SIZE_SHIFT	0
 
arch/powerpc/sysdev/dart_iommu.c +45 -4

79 lines not on this page · raw message

#1 lore raw
Quoted 2 lines

This boots happily on my quad at home,

Boots fine on my quad and seems to survive a bunch of normal tasks. Haven't gotten to do any benchmarking yet.

johannes

#2 lore raw
Quoted 5 lines · Johannes Berg
Quoted 2 lines

This boots happily on my quad at home,

Boots fine on my quad and seems to survive a bunch of normal tasks. Haven't gotten to do any benchmarking yet.

Thanks for testing. I've been running with it all week here as well. I'll try to do some benchmarking this weekend; there are a couple of other things that should be changed in the patch as well.

-Olof