Skip to contentSkip to conversation

fs/inotify.c: cleanups

PATCH In review Adrian Bunk 2 participants 2 messages May 1, 2006 VFS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fs/inotify.c: cleanups

This patch contains the following possible cleanups:
- make the following needlessly global variables static:
- inotify_max_user_instances
- inotify_max_user_watches
- inotify_max_queued_events
- remove the following unused EXPORT_SYMBOL_GPL's:
- inotify_get_cookie
- inotify_unmount_inodes
- inotify_inode_is_dead

---

This patch was already sent on:
- 23 Apr 2006

 fs/inotify.c |    9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)
fs/inotify.c renamed from fs/inotify.c.old +3 -6
@@ -45,9 +45,9 @@
 static struct vfsmount *inotify_mnt __read_mostly;
 
 /* these are configurable via /proc/sys/fs/inotify/ */
-int inotify_max_user_instances __read_mostly;
-int inotify_max_user_watches __read_mostly;
-int inotify_max_queued_events __read_mostly;
+static int inotify_max_user_instances __read_mostly;
+static int inotify_max_user_watches __read_mostly;
+static int inotify_max_queued_events __read_mostly;
 
 /*
  * Lock ordering:
@@ -627,7 +627,6 @@
 {
 	return atomic_inc_return(&inotify_cookie);
 }
-EXPORT_SYMBOL_GPL(inotify_get_cookie);
 
 /**
  * inotify_unmount_inodes - an sb is unmounting.  handle any watched inodes.
@@ -706,7 +705,6 @@
 		spin_lock(&inode_lock);
 	}
 }
-EXPORT_SYMBOL_GPL(inotify_unmount_inodes);
 
 /**
  * inotify_inode_is_dead - an inode has been deleted, cleanup any watches
@@ -725,7 +723,6 @@
 	}
 	mutex_unlock(&inode->inotify_mutex);
 }
-EXPORT_SYMBOL_GPL(inotify_inode_is_dead);
 
 /* Device Interface */
 
Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · Adrian Bunk

This patch contains the following possible cleanups:
- make the following needlessly global variables static:
- inotify_max_user_instances
- inotify_max_user_watches
- inotify_max_queued_events
- remove the following unused EXPORT_SYMBOL_GPL's:
- inotify_get_cookie
- inotify_unmount_inodes
- inotify_inode_is_dead

Quoted 2 lines

Robert Love