Skip to contentSkip to conversation

add __devinitdata to all pci_device_id

ALSA Arjan van de Ven 3 participants 4 messages May 1, 2006 – May 2, 2006 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 7 lines · Linux Kernel Mailing List

commit 396c9b928d5c24775846a161a8191dcc1ea4971f
tree 447f4b28c2dd8e0026b96025fb94dbc654d6cade
parent 71b2ccc3a2fd6c27e3cd9b4239670005978e94ce
author Henrik Kretzschmar <[email protected]> Mon, 24 Apr 2006 15:59:04 +0200 committer Jaroslav Kysela <[email protected]> Thu, 27 Apr 2006 21:10:34 +0200

[ALSA] add __devinitdata to all pci_device_id

are you really really sure you want to do this?
These structures are exported via sysfs for example, I would think this is quite the wrong thing to make go away silently...

#2 lore raw
Quoted 7 lines · Arjan van de Ven
Quoted 6 lines · Linux Kernel Mailing List

commit 396c9b928d5c24775846a161a8191dcc1ea4971f
tree 447f4b28c2dd8e0026b96025fb94dbc654d6cade
parent 71b2ccc3a2fd6c27e3cd9b4239670005978e94ce
author Henrik Kretzschmar <[email protected]> Mon, 24 Apr 2006 15:59:04 +0200 committer Jaroslav Kysela <[email protected]> Thu, 27 Apr 2006 21:10:34 +0200

Quoted 6 lines
Quoted 1 line

[ALSA] add __devinitdata to all pci_device_id

are you really really sure you want to do this?
These structures are exported via sysfs for example, I would think this is quite the wrong thing to make go away silently...

I asked Henrik to not do this, but oh well...

No, if they are marked __devinit, and CONFIG_HOTPLUG is enabled, then the sysfs stuff is enabled. And since CONFIG_HOTPLUG is pretty much always enabled these days, the savings of this kind of patch is non-existant...

greg k-h

#3 lore raw

At Mon, 1 May 2006 09:54:43 -0700,

Quoted 16 lines · Greg KH
Quoted 7 lines · Arjan van de Ven
Quoted 6 lines · Linux Kernel Mailing List

commit 396c9b928d5c24775846a161a8191dcc1ea4971f
tree 447f4b28c2dd8e0026b96025fb94dbc654d6cade
parent 71b2ccc3a2fd6c27e3cd9b4239670005978e94ce
author Henrik Kretzschmar <[email protected]> Mon, 24 Apr 2006 15:59:04 +0200 committer Jaroslav Kysela <[email protected]> Thu, 27 Apr 2006 21:10:34 +0200

Quoted 6 lines
Quoted 1 line

[ALSA] add __devinitdata to all pci_device_id

are you really really sure you want to do this?
These structures are exported via sysfs for example, I would think this is quite the wrong thing to make go away silently...

Quoted 6 lines

I asked Henrik to not do this, but oh well...

No, if they are marked __devinit, and CONFIG_HOTPLUG is enabled, then the sysfs stuff is enabled. And since CONFIG_HOTPLUG is pretty much always enabled these days, the savings of this kind of patch is non-existant...

Then actually what could be a pitfall by adding __devinitdata to pci_device_id table? If there is a potential danger, we should remove these modifiers from all places, especially from Documentation/pci.txt.

thanks,

Takashi

#4 lore raw
Quoted 25 lines · Takashi Iwai

At Mon, 1 May 2006 09:54:43 -0700,

Quoted 16 lines · Greg KH
Quoted 7 lines · Arjan van de Ven
Quoted 6 lines · Linux Kernel Mailing List

commit 396c9b928d5c24775846a161a8191dcc1ea4971f
tree 447f4b28c2dd8e0026b96025fb94dbc654d6cade
parent 71b2ccc3a2fd6c27e3cd9b4239670005978e94ce
author Henrik Kretzschmar <[email protected]> Mon, 24 Apr 2006 15:59:04 +0200 committer Jaroslav Kysela <[email protected]> Thu, 27 Apr 2006 21:10:34 +0200

Quoted 6 lines
Quoted 1 line

[ALSA] add __devinitdata to all pci_device_id

are you really really sure you want to do this?
These structures are exported via sysfs for example, I would think this is quite the wrong thing to make go away silently...

Quoted 6 lines

I asked Henrik to not do this, but oh well...

No, if they are marked __devinit, and CONFIG_HOTPLUG is enabled, then the sysfs stuff is enabled. And since CONFIG_HOTPLUG is pretty much always enabled these days, the savings of this kind of patch is non-existant...

Quoted 4 lines

Then actually what could be a pitfall by adding __devinitdata to pci_device_id table? If there is a potential danger, we should remove these modifiers from all places, especially from Documentation/pci.txt.

There's no real pitfall, only the chance for people to get it wrong (using __initdata instead, or using __devinitdata for hotplug-only drivers.)

thanks,

greg k-h