Skip to contentSkip to conversation

fix audit_krule_to_{rule,data} return values

PATCH New Amy Griffis 1 participant 1 message May 2, 2006 Audit

lore
Share & tools
lore

Amy Griffis

author
#0 lore raw

PATCH 1/1 fix audit_krule_to_{rule,data} return values

Don't return -ENOMEM when callers of these functions are checking for a NULL return. Bug noticed by Serge Hallyn.

Signed-off-by Amy Griffis <[email protected]>
kernel/auditfilter.c +2 -2
index 35dca7e..7647237 100644
@@ -457,7 +457,7 @@ static struct audit_rule *audit_krule_to
 
 	rule = kmalloc(sizeof(*rule), GFP_KERNEL);
 	if (unlikely(!rule))
-		return ERR_PTR(-ENOMEM);
+		return NULL;
 	memset(rule, 0, sizeof(*rule));
 
 	rule->flags = krule->flags | krule->listnr;

@@ -488,7 +488,7 @@ static struct audit_rule_data *audit_kru
 
 	data = kmalloc(sizeof(*data) + krule->buflen, GFP_KERNEL);
 	if (unlikely(!data))
-		return ERR_PTR(-ENOMEM);
+		return NULL;
 	memset(data, 0, sizeof(*data));
 
 	data->flags = krule->flags | krule->listnr;