Skip to contentSkip to conversation

bcm43xx-d80211: Fix access to non-existent PHY registers

PATCH New Michael Buesch 1 participant 1 message May 5, 2006

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bcm43xx-d80211: Fix access to non-existent PHY registers

John, this is the same patch as before, but for d80211. Please apply to wireless-dev.

--

Fix the conditions under which we poke at the APHY registers in bcm43xx_phy_initg() to avoid a machine check on chips where they don't exist.

drivers/net/wireless/d80211/bcm43xx/bcm43xx_phy.c +1 -1
index 45da79d..1816f66 100644
@@ -1287,7 +1287,7 @@ static void bcm43xx_phy_initg(struct bcm
 	if (radio->revision == 8)
 		bcm43xx_phy_write(bcm, 0x0805, 0x3230);
 	bcm43xx_phy_init_pctl(bcm);
-	if (bcm->chip_id == 0x4306 && bcm->chip_package != 2) {
+	if (bcm->chip_id == 0x4306 && bcm->chip_package == 2) {
 		bcm43xx_phy_write(bcm, 0x0429,
 				  bcm43xx_phy_read(bcm, 0x0429) & 0xBFFF);
 		bcm43xx_phy_write(bcm, 0x04C3,
Signature · 1 line
Greetings Michael.