Skip to contentSkip to conversation

add __devinitdata to all pci_device_id

ALSA Henne 2 participants 3 messages May 1, 2006 – May 11, 2006

lore
Share & tools
lore

Henne

author
#0 lore raw
Quoted 3 lines · Arjan van de Ven

are you really really sure you want to do this?
These structures are exported via sysfs for example, I would think this is quite the wrong thing to make go away silently...

Hi there!

Sorry if I didn't mention everything I was .
A couple of devices had __devinitdata on their tables like written in Documentation/pci.txt, so I thought this is something that was forgotten.
How can we get clearness in that topic?

Greets,
Henrik

author
#1 lore raw
Quoted 5 lines · Henne
Quoted 3 lines · Arjan van de Ven

are you really really sure you want to do this?
These structures are exported via sysfs for example, I would think this is quite the wrong thing to make go away silently...

I tested that on my system.

make oldconfig
<comment out CONFIG_HOTPLUG>
<install and booting that kernel>
<reading vendor device, etc. of built-in devices in sysfs>
<adding new ID's via new_id>
no errors, no crash
But that mustn't mean something.
I'll take a look at the pci-driver, but some who is more familiar with that should take a look, too.

Greets,
Henne

#2 lore raw
Quoted 8 lines · Henne
Quoted 5 lines · Henne
Quoted 3 lines · Arjan van de Ven

are you really really sure you want to do this?
These structures are exported via sysfs for example, I would think this is quite the wrong thing to make go away silently...

Quoted 7 lines

I tested that on my system.

make oldconfig
<comment out CONFIG_HOTPLUG>
<install and booting that kernel>
<reading vendor device, etc. of built-in devices in sysfs> <adding new ID's via new_id>

Hm, I don't think you really disabled CONFIG_HOTPLUG, as that file will not be present if you disable that option.

So I think your testing was invalid.

thanks,

greg k-h