Skip to contentSkip to conversation

ethtool always report port is TP on tg3

PATCH Applied Karsten Keil 3 participants 4 messages May 12, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ethtool always report port is TP on tg3

Even with fiber cards ethtool reports that the connected port is TP, the patch fix this.

---

 drivers/net/tg3.c |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)

5ed8e79c778ee803e44a325a1e15c0cb3f52d0ff

drivers/net/tg3.c +5 -3
index beeb612..0b5bc93 100644
@@ -7653,21 +7653,23 @@ static int tg3_get_settings(struct net_d
 		cmd->supported |= (SUPPORTED_1000baseT_Half |
 				   SUPPORTED_1000baseT_Full);
 
-	if (!(tp->tg3_flags2 & TG3_FLG2_ANY_SERDES))
+	if (!(tp->tg3_flags2 & TG3_FLG2_ANY_SERDES)) {
 		cmd->supported |= (SUPPORTED_100baseT_Half |
 				  SUPPORTED_100baseT_Full |
 				  SUPPORTED_10baseT_Half |
 				  SUPPORTED_10baseT_Full |
 				  SUPPORTED_MII);
-	else
+		cmd->port = PORT_TP;
+	} else {
 		cmd->supported |= SUPPORTED_FIBRE;
+		cmd->port = PORT_FIBRE;
+	}
   
 	cmd->advertising = tp->link_config.advertising;
 	if (netif_running(dev)) {
 		cmd->speed = tp->link_config.active_speed;
 		cmd->duplex = tp->link_config.active_duplex;
 	}
-	cmd->port = 0;
 	cmd->phy_address = PHY_ADDR;
 	cmd->transceiver = 0;
 	cmd->autoneg = tp->link_config.autoneg;
Signature · 3 lines
Karsten Keil
SuSE Labs
ISDN development
#1 lore raw
Quoted 2 lines · Karsten Keil

Even with fiber cards ethtool reports that the connected port is TP, the patch fix this.

ACK. Thanks. Please add sign-off line and send to DaveM.

#2 lore raw
Quoted 2 lines · Michael Chan

ACK. Thanks. Please add sign-off line and send to DaveM.

This time with Signed-off line.

Even with fiber cards ethtool reports that the connected port is TP, the patch fix this.

---

 drivers/net/tg3.c |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)

5ed8e79c778ee803e44a325a1e15c0cb3f52d0ff

drivers/net/tg3.c +5 -3
index beeb612..0b5bc93 100644
@@ -7653,21 +7653,23 @@ static int tg3_get_settings(struct net_d
 		cmd->supported |= (SUPPORTED_1000baseT_Half |
 				   SUPPORTED_1000baseT_Full);
 
-	if (!(tp->tg3_flags2 & TG3_FLG2_ANY_SERDES))
+	if (!(tp->tg3_flags2 & TG3_FLG2_ANY_SERDES)) {
 		cmd->supported |= (SUPPORTED_100baseT_Half |
 				  SUPPORTED_100baseT_Full |
 				  SUPPORTED_10baseT_Half |
 				  SUPPORTED_10baseT_Full |
 				  SUPPORTED_MII);
-	else
+		cmd->port = PORT_TP;
+	} else {
 		cmd->supported |= SUPPORTED_FIBRE;
+		cmd->port = PORT_FIBRE;
+	}
   
 	cmd->advertising = tp->link_config.advertising;
 	if (netif_running(dev)) {
 		cmd->speed = tp->link_config.active_speed;
 		cmd->duplex = tp->link_config.active_duplex;
 	}
-	cmd->port = 0;
 	cmd->phy_address = PHY_ADDR;
 	cmd->transceiver = 0;
 	cmd->autoneg = tp->link_config.autoneg;
Signature · 3 lines
Karsten Keil
SuSE Labs
ISDN development