Skip to contentSkip to conversation

Kdump i386 nmi event notification fix

PATCH In review Vivek Goyal 3 participants 3 messages May 15, 2006 – May 16, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Kdump i386 nmi event notification fix

o After a crash we should wait for NMI IPI event and not for external NMI or NMI watchdog tick.

---

 linux-2.6.17-rc4-1M-vivek/arch/i386/kernel/crash.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
arch/i386/kernel/crash.c renamed from arch/i386/kernel/crash.c~kdump-i386-nmi-event-notification-fix +2 -2
diff -puN arch/i386/kernel/crash.c~kdump-i386-nmi-event-notification-fix arch/i386/kernel/crash.c
@@ -102,7 +102,7 @@ static int crash_nmi_callback(struct not
 	struct pt_regs fixed_regs;
 	int cpu;
 
-	if (val != DIE_NMI)
+	if (val != DIE_NMI_IPI)
 		return NOTIFY_OK;
 
 	regs = ((struct die_args *)data)->regs;
@@ -113,7 +113,7 @@ static int crash_nmi_callback(struct not
 	 * an NMI if system was initially booted with nmi_watchdog parameter.
 	 */
 	if (cpu == crashing_cpu)
-		return 1;
+		return NOTIFY_STOP;
 	local_irq_disable();
 
 	if (!user_mode_vm(regs)) {

_

#1 lore raw
Quoted 4 lines · Vivek Goyal

o After a crash we should wait for NMI IPI event and not for external NMI or NMI watchdog tick.

The two patches don't apply anymore after Don's big NMI rework. Can you forward port and retest/resend please?
-Andi

#2 lore raw
Quoted 9 lines · Andi Kleen
Quoted 4 lines · Vivek Goyal

o After a crash we should wait for NMI IPI event and not for external NMI or NMI watchdog tick.

The two patches don't apply anymore after Don's big NMI rework. Can you forward port and retest/resend please?

I have all this stuff queued up against your tree - I'll send it over.