Skip to contentSkip to conversation

added support for ASIX 88178 chipset USB Gigabit Ethernet adaptor

PATCH In review Eduard Warkentin 2 participants 6 messages May 17, 2006 – May 18, 2006 USB

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 added support for ASIX 88178 chipset USB Gigabit Ethernet adaptor

FROM: Eduard Warkentin <[email protected]>

Added support for detetcion an dworking with a ASIX 88178 based USB-Gigabit adaptor. With the patch, it is detected and handled correctly by the asix module.

---<snip>---

drivers/usb/net/asix.c 2006-05-18 01:18:52.000000000 +0200 renamed from drivers/usb/net/asix.c.orig 2006-03-20 06:53:29.000000000 +0100 +4 -0
@@ -913,6 +913,10 @@ static const struct usb_device_id  produc
         USB_DEVICE (0x0b95, 0x7720),
         .driver_info = (unsigned long) &ax88772_info,
 }, {
+  // ASIX AX88178 10/100/1000
+  USB_DEVICE (0x0b95, 0x1780),
+  .driver_info = (unsigned long) &ax88772_info,
+}, {
  // Linksys USB200M Rev 2
  USB_DEVICE (0x13b1, 0x0018),
  .driver_info = (unsigned long) &ax88772_info,

---<snap>---

#1 lore raw
Quoted 10 lines · Eduard Warkentin

FROM: Eduard Warkentin <[email protected]>

Added support for detetcion an dworking with a ASIX 88178 based USB-Gigabit adaptor. With the patch, it is detected and handled correctly by the asix module.

---<snip>---

drivers/usb/net/asix.c 2006-05-18 01:18:52.000000000 +0200 static const struct usb_device_id produc · line 919

Quoted 7 lines
drivers/usb/net/asix.c 2006-05-18 01:18:52.000000000 +0200 renamed from drivers/usb/net/asix.c.orig 2006-03-20 06:53:29.000000000 +0100 +4 -0
@@ -913,6 +913,10 @@ static const struct usb_device_id  produc
         USB_DEVICE (0x0b95, 0x7720),
         .driver_info = (unsigned long) &ax88772_info,
 }, {
+  // ASIX AX88178 10/100/1000
+  USB_DEVICE (0x0b95, 0x1780),
+  .driver_info = (unsigned long) &ax88772_info,
+}, {

Hm, your tabs and spaces are messed up :(

And you didn't CC: the driver maintainer :(

Quoted 6 lines
drivers/usb/net/asix.c 2006-05-18 01:18:52.000000000 +0200 renamed from drivers/usb/net/asix.c.orig 2006-03-20 06:53:29.000000000 +0100 +0 -1
  // Linksys USB200M Rev 2
  USB_DEVICE (0x13b1, 0x0018),
  .driver_info = (unsigned long) &ax88772_info,
---<snap>---

And you put this at the bottom (it goes up in the changelog description) :(

Care to try again?

thanks,

greg k-h

#2 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: RIPEMD160

Hi Greg!

First of all, i hope you arent angry about having me sent this reply as CC to the current maintainer and to the mailing list. If so, I apologize, and it wont happen in future.

Quoted 1 line

Hm, your tabs and spaces are messed up :(

I reviewed the original file again, and the lines just above mine indeed have spare leading whitespaces. Shall I include changing them in my patch? I really dont know wether it just will ok, or will make it harder to identify what i actually did in patch. I have to excuse myself for asking about those details, but this is my very first kernel patch ever. (For now, I left the whitespaces as I found them in the source file. Please, clue me on how to deal with those, wehen i encounter them again.)

So, here's my corrected patch again:

FROM: Eduard Warkentin <[email protected]>

Added support for detetcion an dworking with a ASIX 88178 based USB-Gigabit
adaptor. With the patch, it is detected and handled correctly by the asix module.

- --- ./drivers/usb/net/asix.c.orig 2006-03-20 06:53:29.000000000 +0100 +++ ./drivers/usb/net/asix.c 2006-05-18 01:18:52.000000000 +0200 @@ -913,6 +913,10 @@ static const struct usb_device_id produc

         USB_DEVICE (0x0b95, 0x7720),
         .driver_info = (unsigned long) &ax88772_info,
 }, {
+  // ASIX AX88178 10/100/1000
+  USB_DEVICE (0x0b95, 0x1780),
+  .driver_info = (unsigned long) &ax88772_info,

+}, {
// Linksys USB200M Rev 2
USB_DEVICE (0x13b1, 0x0018),
.driver_info = (unsigned long) &ax88772_info,
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEbOyK0HvYPTIhdZcRA+rAAKCAChGPNe3lCaPcZUNkJujYJmmUZgCgq6tc bTotPl6JBMbch/DpS9O0DEQ=
=1BCn
-----END PGP SIGNATURE-----

#3 lore raw
Quoted 10 lines · Eduard Warkentin

Hi Greg!

First of all, i hope you arent angry about having me sent this reply as CC to the current maintainer and to the mailing list. If so, I apologize, and it wont happen in future.

Quoted 1 line

Hm, your tabs and spaces are messed up :(

I reviewed the original file again, and the lines just above mine indeed have spare leading whitespaces. Shall I include changing them in my patch?

No, your tabs got eaten by your email client, and it happened again:

drivers/usb/net/asix.c 2006-05-18 01:18:52.000000000 +0200 static const struct usb_device_id produc · line 922

Quoted 13 lines
drivers/usb/net/asix.c 2006-05-18 01:18:52.000000000 +0200 renamed from drivers/usb/net/asix.c.orig 2006-03-20 06:53:29.000000000 +0100 +4 -0
@@ -913,6 +913,10 @@ static const struct usb_device_id  produc
         USB_DEVICE (0x0b95, 0x7720),
         .driver_info = (unsigned long) &ax88772_info,
 }, {
+  // ASIX AX88178 10/100/1000
+  USB_DEVICE (0x0b95, 0x1780),
+  .driver_info = (unsigned long) &ax88772_info,
+}, {
  // Linksys USB200M Rev 2
  USB_DEVICE (0x13b1, 0x0018),
  .driver_info = (unsigned long) &ax88772_info,

See, tabs converted to spaces, not good :(

Care for a third try?

thanks,

greg k-h

#4 lore raw
In reply to Eduard Warkentin

-----BEGIN PGP SIGNED MESSAGE-----
Hash: RIPEMD160

Hi!

On to a third try ... carefully watched the tabs this time ...

FROM: Eduard Warkentin <[email protected]>

Added support for detetcion an dworking with a ASIX 88178 based USB-Gigabit adaptor. With the patch, it is detected and handled correctly by the asix module.

- --- ./drivers/usb/net/asix.c.orig 2006-03-20 06:53:29.000000000 +0100 +++ ./drivers/usb/net/asix.c 2006-05-18 01:18:52.000000000 +0200 @@ -913,6 +913,10 @@ static const struct usb_device_id produc

         USB_DEVICE (0x0b95, 0x7720),
         .driver_info = (unsigned long) &ax88772_info,
 }, {
+  // ASIX AX88178 10/100/1000
+  USB_DEVICE (0x0b95, 0x1780),
+  .driver_info = (unsigned long) &ax88772_info,

+}, {
// Linksys USB200M Rev 2
USB_DEVICE (0x13b1, 0x0018),
.driver_info = (unsigned long) &ax88772_info,
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEbPZb0HvYPTIhdZcRAwmvAKDA3mf8PBDfVEj+Wz+B5sa+q60+wwCgxge9 KQ5NIjhZRo3toc6DSW3R01o=
=WG4A
-----END PGP SIGNATURE-----

#5 lore raw
Quoted 3 lines · Eduard Warkentin

Hi!

On to a third try ... carefully watched the tabs this time ...

Nope, it's your email client. Please try another program, or search the archives for how to get Thunderbird to handle patches properly.

thanks,

greg k-h