Skip to contentSkip to conversation

Make printk work for really early debugging

RFC/PATCH Michael Ellerman 3 participants 10 messages May 18, 2006 – May 22, 2006 Console

lore
Share & tools
lore
#0 lore raw

Currently printk is no use for early debugging because it refuses to actually print anything to the console unless cpu_online(smp_processor_id()) is true.

The stated explanation is that console drivers may require per-cpu resources, or otherwise barf, because the system is not yet setup correctly. Fair enough.

However some console drivers might be quite happy running early during boot, in fact we have one, and so it'd be nice if printk understood that.

So I add a flag (which I would have called CON_BOOT, but that's taken) called CON_ANYTIME, which indicates that a console is happy to be called anytime, even if the cpu is not yet online.

Tested on a Power 5 machine, with both a CON_ANYTIME driver and a bogus console driver that BUG()s if called while offline. No problems AFAICT. Built for i386 UP & SMP.

---

 include/linux/console.h |    1 
 kernel/printk.c         |   50 +++++++++++++++++++++++++++++++-----------------
 2 files changed, 34 insertions(+), 17 deletions(-)
include/linux/console.h +1 -0
Index: to-merge/include/linux/console.h
===================================================================
@@ -87,6 +87,7 @@ void give_up_console(const struct consw 
 #define CON_CONSDEV	(2) /* Last on the command line */
 #define CON_ENABLED	(4)
 #define CON_BOOT	(8)
+#define CON_ANYTIME	(16) /* Safe to call when cpu is offline */
 
 struct console
 {
kernel/printk.c +33 -17

80 lines not on this page · raw message

#1 lore raw
Quoted 10 lines · Michael Ellerman

Currently printk is no use for early debugging because it refuses to actually
print anything to the console unless cpu_online(smp_processor_id()) is true.

The stated explanation is that console drivers may require per-cpu resources, or otherwise barf, because the system is not yet setup correctly. Fair enough.

However some console drivers might be quite happy running early during boot, in fact we have one, and so it'd be nice if printk understood that.

Quoted 7 lines

So I add a flag (which I would have called CON_BOOT, but that's taken) called CON_ANYTIME, which indicates that a console is happy to be called anytime, even if the cpu is not yet online.

Tested on a Power 5 machine, with both a CON_ANYTIME driver and a bogus console driver that BUG()s if called while offline. No problems AFAICT. Built for i386 UP & SMP.

hm, OK. But iirc is was just one silly ia64 console driver which had this problem. It might be better to make the new behaviour be the default and mark the ia64 driver CON_NEEDS_CPU_ONLINE or something.

No?

Or go through and audit the drivers and sprinkle CON_ANYTIME in all the safe ones, maybe.

#2 lore raw
Quoted 19 lines · Andrew Morton
Quoted 10 lines · Michael Ellerman

Currently printk is no use for early debugging because it refuses to actually
print anything to the console unless cpu_online(smp_processor_id()) is true.

The stated explanation is that console drivers may require per-cpu resources, or otherwise barf, because the system is not yet setup correctly. Fair enough.

However some console drivers might be quite happy running early during boot, in fact we have one, and so it'd be nice if printk understood that.

Quoted 7 lines

So I add a flag (which I would have called CON_BOOT, but that's taken) called CON_ANYTIME, which indicates that a console is happy to be called anytime, even if the cpu is not yet online.

Tested on a Power 5 machine, with both a CON_ANYTIME driver and a bogus console driver that BUG()s if called while offline. No problems AFAICT. Built for i386 UP & SMP.

Quoted 8 lines

hm, OK. But iirc is was just one silly ia64 console driver which had this problem. It might be better to make the new behaviour be the default and mark the ia64 driver CON_NEEDS_CPU_ONLINE or something.

No?

Or go through and audit the drivers and sprinkle CON_ANYTIME in all the safe ones, maybe.

Quite possibly, I started from the assumption that we liked the current behaviour. Inverting the logic, ie. CON_NEEDS_CPU_ONLINE, would be ok with me, but it would be a much more intrusive change. All of a sudden we'll be calling into all sorts of drivers that we didn't previously.

I'll trawl through the console drivers tomorrow and see if I can guess what percentage look like they will/won't work, then we can decide which way to flip it.

cheers

Signature · 8 lines
Michael Ellerman
IBM OzLabs

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
#3 lore raw
Quoted 4 lines · Michael Ellerman

I'll trawl through the console drivers tomorrow and see if I can guess what percentage look like they will/won't work, then we can decide which way to flip it.

Yes, that's probably safer and saner, thanks. Don't bust a gut over it though - it's not your problem and if someone's hurting from it then they can write and test the patch.

I guess many people are using earlyprintk or console=uart..

#4 lore raw
Quoted 9 lines · Andrew Morton
Quoted 4 lines · Michael Ellerman

I'll trawl through the console drivers tomorrow and see if I can guess what percentage look like they will/won't work, then we can decide which way to flip it.

Yes, that's probably safer and saner, thanks. Don't bust a gut over it though - it's not your problem and if someone's hurting from it then they can write and test the patch.

I had a quick gander at some of the consoles registered under arch. A lot of them look like they'd be ok running with CON_ANYTIME, ie. they just write to a fixed address or uart or something simple.

Having said that I still think we should leave this patch as is, and leave it up to arch people to decide whether they want to add CON_ANYTIME to their particular console driver.

cheers

Signature · 8 lines
Michael Ellerman
IBM OzLabs

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
#5 lore raw
In reply to Michael Ellerman
Quoted 2 lines · Michael Ellerman

Currently printk is no use for early debugging because it refuses to actually print anything to the console unless cpu_online(smp_processor_id()) is true.

On x86-64 this is simply solved by setting the boot processor online very early.

-Andi

#6 lore raw
Quoted 6 lines · Andi Kleen
Quoted 2 lines · Michael Ellerman

Currently printk is no use for early debugging because it refuses to actually print anything to the console unless cpu_online(smp_processor_id()) is true.

On x86-64 this is simply solved by setting the boot processor online very early.

Yeah, someone suggested that. Unfortunately it doesn't work, we actually want to call printk before we even know which cpu we're on :D

cheers

Signature · 8 lines
Michael Ellerman
IBM OzLabs

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
#7 lore raw
Quoted 10 lines · Michael Ellerman
Quoted 6 lines · Andi Kleen
Quoted 2 lines · Michael Ellerman

Currently printk is no use for early debugging because it refuses to actually print anything to the console unless cpu_online(smp_processor_id()) is true.

On x86-64 this is simply solved by setting the boot processor online very early.

Yeah, someone suggested that. Unfortunately it doesn't work, we actually want to call printk before we even know which cpu we're on :D

You mean smp_processor_id() returns a random value?

Then your patch is broken too because iirc it tested smp_processor_id() before that other flag

-Andi

#8 lore raw
Quoted 9 lines · Andi Kleen
Quoted 8 lines · Michael Ellerman
Quoted 6 lines · Andi Kleen
Quoted 2 lines · Michael Ellerman

Currently printk is no use for early debugging because it refuses to actually print anything to the console unless cpu_online(smp_processor_id()) is true.

On x86-64 this is simply solved by setting the boot processor online very early.

Quoted 7 lines
Quoted 2 lines

Yeah, someone suggested that. Unfortunately it doesn't work, we actually want to call printk before we even know which cpu we're on :D

You mean smp_processor_id() returns a random value?

Then your patch is broken too because iirc it tested smp_processor_id() before that other flag

No it returns 0, but that seems to be the result of good luck rather than good management. I think I owe you a beer :)

cheers

Signature · 8 lines
Michael Ellerman
IBM OzLabs

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
#9 lore raw
In reply to Andi Kleen
Quoted 6 lines · Andi Kleen
Quoted 2 lines · Michael Ellerman

Currently printk is no use for early debugging because it refuses to actually print anything to the console unless cpu_online(smp_processor_id()) is true.

On x86-64 this is simply solved by setting the boot processor online very early.

I had a closer look at this, and we could actually fudge it so that cpu_online() is true in our early boot code, even though we don't know what cpu we're on.

But that kind of begs the question, what does "cpu_online(x)" actually mean? If it doesn't mean percpu data is allocated, what does it mean?

cheers

Signature · 8 lines
Michael Ellerman
IBM OzLabs

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person