Skip to contentSkip to conversation

edac driver names in sysfs.

DISCUSSION Dave Jones 3 participants 3 messages May 22, 2006 – May 23, 2006

lore
Share & tools
lore

Dave Jones

author
#0 lore raw

EDAC does something funky that no other afaik seems to do.

#define edac_xstr(s) edac_str(s)
#define edac_str(s) #s
#define EDAC_MOD_STR edac_xstr(KBUILD_BASENAME)

And then..

.name = EDAC_MOD_STR,

in its pci_driver structs.
This leads to it looking a bit 'odd' in /sys/bus/pci/drivers compared to the others.

/sys/bus/pci/drivers/\"e752x_edac\"/

Is correcting this to remove the quotes likely to break anything in userspace ?

Dave

Signature · 1 line
http://www.codemonkey.org.uk
#1 lore raw
Quoted 9 lines · Dave Jones (on Sun, 21 May 2006 22:29:12 -0400) wrote:

EDAC does something funky that no other afaik seems to do.

#define edac_xstr(s) edac_str(s)
#define edac_str(s) #s
#define EDAC_MOD_STR edac_xstr(KBUILD_BASENAME)

And then..

.name = EDAC_MOD_STR,

EDAC is reinventing the wheel. We have the standard

#include <linux/stringify.h>

.name = __stringify(KBUILD_BASENAME).

#2 lore raw
In reply to Dave Jones
Quoted 10 lines · Dave Jones

EDAC does something funky that no other afaik seems to do.

#define edac_xstr(s) edac_str(s)
#define edac_str(s) #s
#define EDAC_MOD_STR edac_xstr(KBUILD_BASENAME)

And then..

.name = EDAC_MOD_STR,

Quoted 8 lines

in its pci_driver structs.
This leads to it looking a bit 'odd' in /sys/bus/pci/drivers compared to the others.

/sys/bus/pci/drivers/\"e752x_edac\"/

Is correcting this to remove the quotes likely to break anything in userspace ?

In the /sys/bus/pci/drivers/ directory? No, it should be fixed. Driver names shouldn't have quotes or spaces or / in them. I've fixed up almost all of the space issues, but they seem to keep cropping up every once in a while (an example of this is the name "Intel ICH" which should be fixed up...

thanks,

greg k-h