Skip to contentSkip to conversation

moxa: remove pointless check of 'tty' argument vs NULL

PATCH RESEND New Jesper Juhl 1 participant 1 message May 22, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH RESEND 2/3 moxa: remove pointless check of 'tty' argument vs NULL

(This patch was originaly send on 15/05-2006 - this is a resend.
Patch still applies cleanly to 2.6.17-rc4-mm3)

Remove pointless check of 'tty' argument vs NULL from moxa driver. (applies on top of patch 1/3)

(Discussion about the patch when it was initially posted resulted in agreement that this is the right thing to do.)

---

 drivers/char/mxser.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/char/mxser.c renamed from drivers/char/mxser.c.1 +2 -2
@@ -1081,7 +1081,7 @@ static int mxser_write(struct tty_struct
 	struct mxser_struct *info = tty->driver_data;
 	unsigned long flags;
 
-	if (!tty || !info->xmit_buf)
+	if (!info->xmit_buf)
 		return (0);
 
 	while (1) {
@@ -1117,7 +1117,7 @@ static void mxser_put_char(struct tty_st
 	struct mxser_struct *info = tty->driver_data;
 	unsigned long flags;
 
-	if (!tty || !info->xmit_buf)
+	if (!info->xmit_buf)
 		return;
 
 	if (info->xmit_cnt >= SERIAL_XMIT_SIZE - 1)