Skip to contentSkip to conversation

turn off b44 module on x86_64, it breaks the build

PATCH In review Sean Dague 2 participants 5 messages May 26, 2006 – May 30, 2006

lore
Share & tools
lore

Sean Dague

author
#0 lore raw

PATCH 1/1 turn off b44 module on x86_64, it breaks the build

The attached patch turns off the b44 module on x86_64 xen kernel, as it breaks the build.

Note, this was applied many moons ago, and reverted again at some point later.

-Sean

Signature · 3 lines
Sean Dague
IBM Linux Technology Center                     email: [email protected]
Open Hypervisor Team                           alt: [email protected]

# HG changeset patch
# User [email protected]
# Node ID a66b63752e47af3f7edb08da6931b59e5c3a9da7 # Parent 218daa547e8afdd3a327df6402cef1af8ae54f2c Turn off B44 module on x86_64 (for the second time)

buildconfigs/linux-defconfig_xen_x86_64 +2 -2
diff -r 218daa547e8a -r a66b63752e47 buildconfigs/linux-defconfig_xen_x86_64
@@ -1,7 +1,7 @@
 #
 # Automatically generated make config: don't edit
 # Linux kernel version: 2.6.16.13-xen
-# Thu May 11 17:18:58 2006
+# Fri May 26 11:30:53 2006
 #
 CONFIG_X86_64=y
 CONFIG_64BIT=y
@@ -1257,7 +1257,7 @@ CONFIG_AMD8111E_NAPI=y
 CONFIG_AMD8111E_NAPI=y
 CONFIG_ADAPTEC_STARFIRE=m
 CONFIG_ADAPTEC_STARFIRE_NAPI=y
-CONFIG_B44=m
+# CONFIG_B44 is not set
 CONFIG_FORCEDETH=m
 CONFIG_DGRS=m
 CONFIG_EEPRO100=m

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

author
#1 lore raw
Quoted 5 lines · Sean Dague

The attached patch turns off the b44 module on x86_64 xen kernel, as it breaks the build.

Note, this was applied many moons ago, and reverted again at some point later.

It would be really good if this patch was applied. Default x84_64 builds of xen break at the moment. This patch (more or less) was originally applied on March 27 as changeset 40c23921e7295650305c4e4db2480756e9b3e10c, but has since been reverted.

-Sean

Signature · 3 lines
Sean Dague
IBM Linux Technology Center                     email: [email protected]
Open Hypervisor Team                           alt: [email protected]

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

#2 lore raw
Quoted 4 lines · Sean Dague

It would be really good if this patch was applied. Default x84_64 builds of xen break at the moment. This patch (more or less) was originally applied on March 27 as changeset 40c23921e7295650305c4e4db2480756e9b3e10c, but has since been reverted.

How does it break the build? We build -xen kernels as part of automatic regression tests and haven't seen any build failures.

-- Keir

author
#3 lore raw
Quoted 11 lines · Keir Fraser
Quoted 7 lines · Sean Dague

It would be really good if this patch was applied. Default x84_64 builds of
xen break at the moment. This patch (more or less) was originally applied
on March 27 as changeset 40c23921e7295650305c4e4db2480756e9b3e10c, but has
since been reverted.

Quoted 2 lines

How does it break the build? We build -xen kernels as part of automatic regression tests and haven't seen any build failures.

I get the following out of a 'make install' from the xen-unstable tree on x86_64:

...
INSTALL sound/usb/snd-usb-lib.ko
INSTALL sound/usb/usx2y/snd-usb-usx2y.ko
if [ -r System.map -a -x /sbin/depmod ]; then /sbin/depmod -ae -F System.map -b / -r 2.6.16.13-xen; fi
WARNING: //lib/modules/2.6.16.13-xen/kernel/drivers/net/b44.ko needs unknown symbol dma_get_cache_alignment
make[3]: *** [_modinst_post] Error 1
make[3]: Leaving directory `/home/sdague/xen-unstable-fresh/linux-2.6.16.13-xen'
make[2]: *** [build] Error 2
make[2]: Leaving directory `/home/sdague/xen-unstable-fresh' make[1]: *** [linux-2.6-xen-install] Error 2
make[1]: Leaving directory `/home/sdague/xen-unstable-fresh'
make: *** [install-kernels] Error 1

Which thus is a broken build process.

Removal of the b44 module, which won't work anyway given the unresolved symbols, removes this failure on 'make install', so it runs through clean.

-Sean

Signature · 3 lines
Sean Dague
IBM Linux Technology Center                     email: [email protected]
Open Hypervisor Team                           alt: [email protected]

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

#4 lore raw
Quoted 2 lines

Removal of the b44 module, which won't work anyway given the unresolved symbols, removes this failure on 'make install', so it runs through clean.

Sean,

Please let me know whether the attached patch fixes this build breakage for you.

-- Keir

linux-2.6-xen-sparse/include/asm-i386/mach-xen/asm/dma-mapping.h +0 -2
diff -r e58e04589d11 linux-2.6-xen-sparse/include/asm-i386/mach-xen/asm/dma-mapping.h
@@ -128,8 +128,6 @@
 	 * maximum possible, to be safe */
 	return (1 << INTERNODE_CACHE_SHIFT);
 }
-#else
-extern int dma_get_cache_alignment(void);
 #endif
 
 #define dma_is_consistent(d)	(1)

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel