Skip to contentSkip to conversation

APM suspend to RAM broken, culprit found

DISCUSSION Matt Mackall 2 participants 3 messages May 26, 2006

lore
Share & tools
lore
#0 lore raw

Bisection reveals that the patch entitled:

[PATCH] swsusp: add check for suspension of X-controlled devices

breaks resume of ipw2200, synaptics mouse, USB, and probably other useful bits on my Thinkpad R51. Notably, I'm using APM.

Signature · 1 line
Mathematics is the supreme nostalgia of our time.
#1 lore raw
Quoted 8 lines · Matt Mackall

Bisection reveals that the patch entitled:

[PATCH] swsusp: add check for suspension of X-controlled devices

breaks resume of ipw2200, synaptics mouse, USB, and probably other useful bits on my Thinkpad R51. Notably, I'm using APM.

Would that be because APM remains in X while suspending, but swsusp flicks back to VT mode?

Anyway, I'll queue a revert patch for 2.6.17, thanks.

#2 lore raw
Quoted 4 lines · Andrew Morton
Quoted 3 lines · Matt Mackall

Bisection reveals that the patch entitled:

Quoted 8 lines
Quoted 5 lines

[PATCH] swsusp: add check for suspension of X-controlled devices

breaks resume of ipw2200, synaptics mouse, USB, and probably other useful bits on my Thinkpad R51. Notably, I'm using APM.

Would that be because APM remains in X while suspending, but swsusp flicks back to VT mode?

Probably something like that.

I believe the patch description is a bit misleading as well. Obviously my wireless adapter is not "X-controlled".

Quoted 1 line

Anyway, I'll queue a revert patch for 2.6.17, thanks.

For the record, I've booted tip patched with this code disabled and everything's happy again.

Signature · 1 line
Mathematics is the supreme nostalgia of our time.