Skip to contentSkip to conversation

libata: set PIO-0 after successful EH reset

PATCH New Tejun Heo 1 participant 1 message May 29, 2006

Subsystems (2)
lore
Share & tools
lore

Tejun Heo

author
#0 lore raw

PATCH 1/1 libata: set PIO-0 after successful EH reset

Set ata_device->pio_mode to XFER_PIO_0 after a successful reset. This is to keep EH resets consistent with probe resets as updated by the commit b6079ca409bf88c248992e96510dd6f610f7ed89. Note that, with soon-to-follow hotplug update, EH resets will include probe resets.

---

 drivers/scsi/libata-eh.c |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)

8bdb768ad75508fcc0e26ed15723700e40b9f619

drivers/scsi/libata-eh.c +7 -1
index 71b45ad..b88f492 100644
@@ -1287,7 +1287,7 @@ static int ata_eh_reset(struct ata_port 
 	unsigned int classes[ATA_MAX_DEVICES];
 	int tries = ATA_EH_RESET_TRIES;
 	ata_reset_fn_t reset;
-	int rc;
+	int i, rc;
 
 	if (softreset && (!hardreset || (!sata_set_spd_needed(ap) &&
 					 !(ehc->i.action & ATA_EH_HARDRESET))))
@@ -1319,6 +1319,12 @@ static int ata_eh_reset(struct ata_port 
 	}
 
 	if (rc == 0) {
+		/* After the reset, the device state is PIO 0 and the
+		 * controller state is undefined.  Record the mode.
+		 */
+		for (i = 0; i < ATA_MAX_DEVICES; i++)
+			ap->device[i].pio_mode = XFER_PIO_0;
+
 		if (postreset)
 			postreset(ap, classes);
 
Signature · 1 line
1.3.2