jgarzik and max-sectors: out of memory
ATA_MAX_SECTORS is 200, rather than than 256 like it should be. I seem to recall that this was due to libata being incomplete in some area, but I've tried in vain for a year to remember where the alleged incompleteness was, to no avail. So, my brain is out of memory :)
Further -- someone with a long ATA memory correct me -- I think that we can increase ATA_MAX_PRD beyond 256. Most DMA engines should just keep chugging along, provided that we continue to respect the 64k IDE DMA boundaries.
So, I propose that we rename ATA_MAX_SECTORS to ATA_LBA28_SECTORS, and change its value to 256, and see what happens. People have reported that that worked for them, so let's subject it to a wide test. If people are extremely paranoid, we could increase it to 255, and then in the next kernel version, bump it from 255 to 256.
Then we can look at increasing ATA_MAX_PRD, if that's feasible for PATA hardware.
Jeff
Jeff Garzik wrote:
..
Quoted 1 line
Further -- someone with a long ATA memory correct me -- I think that we can increase
ATA_MAX_PRDbeyond 256. Most DMA engines should just keep chugging along, provided that we continue to respect the 64k IDE DMA boundaries.
MAX_PRD used to be equal to MAX_SECTORS, as that's the worst case scenario. The only real gotcha I remember from the original IDE driver, was that some (very few) controllers were buggy with handing
of a sector_count of zero (256), so setting the limit to a slightly lower value prevented that from ever being a problem.
That was in the days before the block layer could limit the segment count.
I don't remember which chipsets had the bug; TRM290 was one, but that never really worked well anyway, and nobody other than myself seemed to have one of those cards. Mmm.. Possibly the Pacific Digital ADMA-100 here as well.. I can look that one up if I can find the old box full of cards/docs..
Cheers
Quoted 5 lines · Mark Lord
Jeff Garzik wrote:
..Quoted 1 line
Further -- someone with a long ATA memory correct me -- I think that we can increase
ATA_MAX_PRDbeyond 256. Most DMA engines should just keep chugging along, provided that we continue to respect the 64k IDE DMA boundaries.
MAX_PRDused to be equal toMAX_SECTORS, as that's the worst case scenario.
Not for lba48, which has a larger max-sectors but is still clamped to the same 256 PRD entries...
Quoted 4 lines
The only real gotcha I remember from the original IDE driver, was that some (very few) controllers were buggy with handing of a
sector_countof zero (256), so setting the limit to a slightly lower value prevented that from ever being a problem.
Yeah, a couple of Alan's PATA drivers are fixed at 255.
Quoted 1 line
That was in the days before the block layer could limit the segment count.
Ahhhhh, useful to know.
Jeff
Quoted 9 lines · Jeff Garzik
ATA_MAX_SECTORSis 200, rather than than 256 like it should be. I seem to recall that this was due to libata being incomplete in some area, but I've tried in vain for a year to remember where the alleged incompleteness was, to no avail. So, my brain is out of memory :)Further -- someone with a long ATA memory correct me -- I think that we can increase
ATA_MAX_PRDbeyond 256. Most DMA engines should just keep chugging along, provided that we continue to respect the 64k IDE DMA boundaries.
The PRD count is much less of a problem.
Quoted 8 lines
So, I propose that we rename
ATA_MAX_SECTORStoATA_LBA28_SECTORS, and change its value to 256, and see what happens. People have reported that that worked for them, so let's subject it to a wide test. If people are extremely paranoid, we could increase it to 255, and then in the next kernel version, bump it from 255 to 256.Then we can look at increasing
ATA_MAX_PRD, if that's feasible for PATA hardware.
Yep lets please do that, I don't think libata ever had any problems with 256 sectors other than perhaps a worry that it would break "something" :-)
Jens
Quoted 1 line · Jens Axboe
Yep lets please do that, I don't think libata ever had any problems with 256 sectors other than perhaps a worry that it would break "something" :-)
There were definite bugs in the past with 256 (versus <= 255) sectors...
Jeff
Quoted 5 lines · Jeff Garzik
Quoted 2 lines · Jens Axboe
Yep lets please do that, I don't think libata ever had any problems with 256 sectors other than perhaps a worry that it would break "something" :-)
There were definite bugs in the past with 256 (versus <= 255) sectors...
Hardware or software? IIRC, the hardware ones were largely an urban legend.
Signature · 1 line
Jens Axboe
Quoted 9 lines · Jens Axboe
Quoted 5 lines · Jeff Garzik
Quoted 2 lines · Jens Axboe
Yep lets please do that, I don't think libata ever had any problems with 256 sectors other than perhaps a worry that it would break "something" :-)
There were definite bugs in the past with 256 (versus <= 255) sectors...
Hardware or software? IIRC, the hardware ones were largely an urban legend.
Software.
Alan is submitting a couple PATA drivers limited to 255 though...
Jeff
Quoted 6 lines · Jeff Garzik
Quoted 5 lines · Jens Axboe
Quoted 4 lines · Jeff Garzik
Quoted 2 lines · Jens Axboe
Yep lets please do that, I don't think libata ever had any problems with 256 sectors other than perhaps a worry that it would break "something" :-)
Quoted 8 lines
Quoted 4 lines
Quoted 1 line
There were definite bugs in the past with 256 (versus <= 255) sectors...
Hardware or software? IIRC, the hardware ones were largely an urban legend.
Software.
Alan is submitting a couple PATA drivers limited to 255 though...
And I'm sure some are even lower than that. Of course libata should be be imposing anything on the driver, the logic that drivers/ide uses for this is actually pretty sane:
if (device_lba28)
max_hw_sectors = 256;
if (device_lba48)
max_hw_sectors = 65536;
if (max_sectors > more_than_controller_supports)
max_sectors = more_than_controller_supports;or something close to that.
Signature · 1 line
Jens Axboe
Quoted 4 lines · Jens Axboe
And I'm sure some are even lower than that. Of course libata should be be imposing anything on the driver, the logic that
drivers/ideuses for this is actually pretty sane:
Quoted 8 lines
if (device_lba28) max_hw_sectors = 256; if (device_lba48) max_hw_sectors = 65536; if (max_sectors > more_than_controller_supports) max_sectors = more_than_controller_supports;or something close to that.
libata has always done this, modulo the ATA_MAX_SECTORS issue.
Jeff
Quoted 12 lines · Jeff Garzik
Quoted 11 lines · Jens Axboe
And I'm sure some are even lower than that. Of course libata should be be imposing anything on the driver, the logic that
drivers/ideuses for this is actually pretty sane:if (device_lba28) max_hw_sectors = 256; if (device_lba48) max_hw_sectors = 65536; if (max_sectors > more_than_controller_supports) max_sectors = more_than_controller_supports;
Quoted 3 lines
Quoted 1 line
or something close to that.
libata has always done this, modulo the
ATA_MAX_SECTORSissue.
I thought so, but then I don't understand your last mail - there's no problem with 255 sector drivers, then.
Signature · 1 line
Jens Axboe