Skip to contentSkip to conversation

fix null dereference in fs audit patch

PATCH New Amy Griffis 1 participant 1 message May 30, 2006 Audit

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix null dereference in fs audit patch

Check watch pointer before dereferencing.

Al, please fold in with latest filesystem auditing patch 1d9d3267853cc4368c923f1ab7037db8c8805b73.

kernel/auditfilter.c +2 -1
index 7f2fcd6..f993842 100644
@@ -1032,12 +1032,13 @@ static inline int audit_do_del_rule(stru
 
 	list_for_each_entry(e, list, list) {
 		struct audit_watch *watch = e->rule.watch;
-		struct audit_parent *parent = watch->parent;
 
 		if (audit_compare_rule(&entry->rule, &e->rule))
 			continue;
 
 		if (watch) {
+			struct audit_parent *parent = watch->parent;
+
 			list_del(&e->rule.rlist);
 
 			if (list_empty(&watch->rules)) {
Signature · 1 line
1.3.0