Skip to contentSkip to conversation

block device write verify test 3rd attempt

PATCH Applied Harry Butterworth 2 participants 2 messages May 25, 2006 – Jun 1, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 block device write verify test 3rd attempt

The differences from the last version of the patch are that...

1) The patch no longer enables fancy head in the BusyBox config.
2) The patch uses dd rather than head -c.
3) The patch uses cat /sys/block/hda1/size in place of cat /dev/hda1 | wc -c. This gives maybe a 30% performance improvement at the cost of a dependency on the sys filesystem layout and contents.

Quoted 1 line

From the patch:

+# This test imports a ram disk device as a physical device into a domU. +# The domU initialises the ram disk with data from /dev/urandom and calculates
+# the md5 checksum of the data (using tee as it is written so as to avoid
+# reading it back from the device which might potentially mask problems).
+# The domU is stopped and the md5 checksum of the data on the device is +# calculated by dom0. The test succeeds if the checksums match, indicating
+# that all the data written by domU was sucessfully committed to the device.
+

This patch also enables tee in BusyBox on the ramdisk and increments the xm-test minor version number. I have tested the patch (again for this 3rd version) with both make existing' where the tests run but the new test fails because the ramdisk is missing tee and make` where the test builds the new ramdisk and passes successfully.

The patch also installs the block-integrity tests in the default test set so they get executed.

tools/xm-test/configure.ac +1 -1
diff -r ad33b3882867 -r 6bc9f9dd31ac tools/xm-test/configure.ac
@@ -1,7 +1,7 @@
 # xm-test configure.ac input script
 
 # Basic header information
-AC_INIT([xm-test], [0.7.1])
+AC_INIT([xm-test], [0.7.2])
 AM_INIT_AUTOMAKE([1.7 foreign])
 
 # Check for dependencies
tools/xm-test/grouptest/default +1 -0
diff -r ad33b3882867 -r 6bc9f9dd31ac tools/xm-test/grouptest/default
@@ -1,6 +1,7 @@
 block-create
 block-destroy
 block-list
+block-integrity
 console
 create
 destroy
tools/xm-test/ramdisk/configs/busybox +2 -2
diff -r ad33b3882867 -r 6bc9f9dd31ac tools/xm-test/ramdisk/configs/busybox
@@ -127,8 +127,8 @@
 CONFIG_SYNC=y
 CONFIG_TAIL=y
 CONFIG_FEATURE_FANCY_TAIL=n
-CONFIG_TEE=n
-CONFIG_FEATURE_TEE_USE_BLOCK_IO=n
+CONFIG_TEE=y
+CONFIG_FEATURE_TEE_USE_BLOCK_IO=y
 CONFIG_TEST=y
 
 #
tools/xm-test/tests/block-integrity/Makefile.am +2 -1
diff -r ad33b3882867 -r 6bc9f9dd31ac tools/xm-test/tests/block-integrity/Makefile.am
@@ -1,7 +1,8 @@
 
 SUBDIRS =
 
-TESTS = 01_block_device_read_verify.test
+TESTS = 01_block_device_read_verify.test \
+        02_block_device_write_verify.test
 
 XFAIL_TESTS = 
 
tools/xm-test/tests/block-integrity/02_block_device_write_verify.py new file +63 -0

63 lines not on this page · raw message

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

Applied
#1 lore raw
Quoted 26 lines · Harry Butterworth

The differences from the last version of the patch are that...

1) The patch no longer enables fancy head in the BusyBox config.
2) The patch uses dd rather than head -c.
3) The patch uses cat /sys/block/hda1/size in place of cat /dev/hda1 | wc -c. This gives maybe a 30% performance improvement at the cost of a dependency on the sys filesystem layout and contents.

Quoted 1 line

From the patch:

(quoted diff) +2 -0
+# This test imports a ram disk device as a physical device into a domU.
+# The domU initialises the ram disk with data from /dev/urandom and

calculates
+# the md5 checksum of the data (using tee as it is written so as to avoid
+# reading it back from the device which might potentially mask problems).

(quoted diff) +2 -0
+# The domU is stopped and the md5 checksum of the data on the device is
+# calculated by dom0.  The test succeeds if the checksums match,

indicating
+# that all the data written by domU was sucessfully committed to the device.
+

Quoted 8 lines

This patch also enables tee in BusyBox on the ramdisk and increments the xm-test minor version number. I have tested the patch (again for this 3rd version) with both make existing' where the tests run but the new test fails because the ramdisk is missing tee and make` where the test builds the new ramdisk and passes successfully.

The patch also installs the block-integrity tests in the default test set so they get executed.

Applied, thanks Harry. I've bumped the version number to 0.8, not 0.7.2 -- if the ramdisk changes, you need to bump the middle digit.

Everyone -- this means that you'll have to download or build a new ramdisk. A new one will be on xm-test by the end of the day.

Cheers,

Ewan.