Skip to contentSkip to conversation

genirq: handle_fasteoi_irq(): do not ->mask()

PATCH New Ingo Molnar 1 participant 1 message Jun 2, 2006 IRQ

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 genirq: handle_fasteoi_irq(): do not ->mask()

Subject: genirq: handle_fasteoi_irq(): do not ->mask()
From: Ingo Molnar <[email protected]>

Ben noticed an inefficiency in the handle_fasteoi_irq() flow
handler: it does a spurious ->mask() call. (That call is not needed - if something did a disable_irq() then it would have masked the irq itself.)

i tested the fix on all affected fasteoi platforms: x86 and x86_64, on both UP and SMP.

---
 kernel/irq/chip.c |    2 --
 1 file changed, 2 deletions(-)
kernel/irq/chip.c +0 -2
Index: linux/kernel/irq/chip.c
===================================================================
@@ -324,8 +324,6 @@ handle_fasteoi_irq(unsigned int irq, str
 	spin_lock(&desc->lock);
 	desc->status &= ~IRQ_INPROGRESS;
 out:
-	if (unlikely(desc->status & IRQ_DISABLED))
-		desc->chip->mask(irq);
 	desc->chip->eoi(irq);
 
 	spin_unlock(&desc->lock);