Fix fbcon limited scroll in SCROLL_PAN_REDRAW mode

PATCH New Malcolm Parsons 1 participant 1 message Jun 6, 2006

Subsystems (2)

Framebuffer layer Console

lore

Share & tools

lore

Malcolm Parsons

author

2006-06-06 01:32 UTC #0 lore raw

PATCH 1/1 Fix fbcon limited scroll in SCROLL_PAN_REDRAW mode

When scrolling up in SCROLL_PAN_REDRAW mode with a large limited scroll region, the bottom few lines have to be redrawn. Without this patch, the wrong text is drawn into these lines, corrupting the display.

Observed in 2.6.14 when running an IRC client in the Nintendo DS linux port.

I haven't tested if scrolling down has the same problem.

Patch against 2.6.17-rc5 (git):

drivers/video/console/fbcon.c +1 -1

index 953eb8c..47ba1a7 100644
@@ -1745,7 +1745,7 @@ static int fbcon_scroll(struct vc_data *
 					fbcon_redraw_move(vc, p, 0, t, count);
 				ypan_up_redraw(vc, t, count);
 				if (vc->vc_rows - b > 0)
-					fbcon_redraw_move(vc, p, b - count,
+					fbcon_redraw_move(vc, p, b,
 							  vc->vc_rows - b, b);
 			} else
 				fbcon_redraw_move(vc, p, t + count, b - t - count, t);